Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 - Sorting options missing and ambiguous #23

Open
theshillito opened this issue Jul 4, 2024 · 3 comments
Open

v2.0.0 - Sorting options missing and ambiguous #23

theshillito opened this issue Jul 4, 2024 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@theshillito
Copy link

"Order By" used to have "Product Title", "Purchase Date", etc. Now it's replaced by an ambiguous "Descending" and "Ascending" selection, which seems to be product release date, and that's the only option.
image
Old style can be seen in https://github.com/AcrylicShrimp/dlsite-manager/blob/main/docs/img-list.png

Could the older sort options be added back in please (I always had it as order by purchase date, since anything I just bought should be at the top). In the interim, this could be better labelled to say what is being ordered.

@AcrylicShrimp
Copy link
Owner

AcrylicShrimp commented Jul 11, 2024

Let me explain some:

  1. Old style order-by filter is gone, because many fields of product table are removed. This is needed to support indexing "not-owned" products, since DLsite is not giving much product informations for "not-owned" compared to the "owned" ones.
  2. So currently, there is only one field that can be used for order-by filter, is "purchased date" field. The order-by filter after reworking is using this.
  3. But I think the order-by filter behavior is somewhat broken.

Conclusion:

  • Let me fix the order-by filter to correctly sort products by purchased date.
  • But I'm not sure I can restore previous filter options. If you really need sort options other than "purchased date", let me know, I'll consider to re-implement them.

@AcrylicShrimp AcrylicShrimp self-assigned this Jul 11, 2024
@AcrylicShrimp AcrylicShrimp added bug Something isn't working enhancement New feature or request labels Jul 11, 2024
@theshillito
Copy link
Author

"purchased date" is really all I want, and the removal of the other sort options makes sense due to lack of data.

For the "not-owned" products, if no "purchased date" is available, is the intention to use folder "creation date" or "modified date" perhaps?

@AcrylicShrimp
Copy link
Owner

Ah, there was an error in my comment. Currently products are sorted by "registered at", not "purchased date". I'm sorry.

I'll change it to use "purchased date" in next release. And yes, I think I can use ctime or atime for "not-owned' ones. Which do you prefer? I think ctime is typically set by the product maker, so it's better to use atime maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants