Fix flattening tracks sometimes splits contiguous clips into segments issue #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rameshbabuvfxtd
force-pushed
the
1635_fix_flatten_issue
branch
from
44243bf to
4e4d499
Compare
github-actions
bot
added
time calculations
documentation
opentime
python-bindings
labels
rameshbabuvfxtd
force-pushed
the
1635_fix_flatten_issue
branch
from
4e4d499 to
c68eb2e
Compare
github-actions
bot
removed
time calculations
documentation
opentime
python-bindings
labels
rameshbabuvfxtd
force-pushed
the
1635_fix_flatten_issue
branch
2 times, most recently
from
4efa44a to
425f948
Compare
…uous clips issue and add tests Signed-off-by: Ramesh Maddhu <rameshm@netflixanimation.com> Signed-off-by: Mark Reid <markreid@netflixanimation.com>
rameshbabuvfxtd
force-pushed
the
1635_fix_flatten_issue
branch
from
425f948 to
e875424
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the flattening tracks issue. When an invisible item like Gap is on an upper track, it chops the clip below when flattening.
Fixes #1635
Example of flatten stack:
The source edit file contains two tracks: the top track has two gaps, and the bottom track has one clip.
Before the fix
When the flattening process was performed, it incorrectly split the clip into two segments, which was not the intended behavior.
After the fix
The flattening process now correctly maintains the clip as a single segment, ensuring that the track contains one continuous clip.
Reference associated tests.
The
test_stack_algo.cppfile has been updated to include new tests for the flatten_stack function.