Switch python build to scikit-build-core #1816
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
JeanChristopheMorinPerso
force-pushed
the
switch_to_scikit_build_core
branch
from
da5a372 to
834c335
Compare
| @@ -93,6 +93,7 @@ jobs: | |||
| py_build_test: | |||
| runs-on: ${{ matrix.os }} | |||
| strategy: | |||
| fail-fast: false | |||
There was a problem hiding this comment.
Suggested change
| fail-fast: false |
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", |
There was a problem hiding this comment.
Suggested change
| "Programming Language :: Python :: 3.11", | |
| "Programming Language :: Python :: 3.11", | |
| "Programming Language :: Python :: 3.12", |
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
JeanChristopheMorinPerso
force-pushed
the
switch_to_scikit_build_core
branch
from
fe10872 to
3b1f0b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
The current python builds use setuptools which is really complicated and hard to maintain. This PR replaces setuptools with a more recent and modern build backend that was specifically designed to support CMake+Python. That backend is scikit-build-core.
Note that this is not the old
scikit-build. It's from the same people, but it's not the same thing.scikit-builwas building on top of setuptools.scikit-build-coreis a complete rewrite and doesn't rely on setuptools.This makes the build, debugging and packaging experience much better.
scikit-build-coreis now widely used and has active maintainers. It's also used by other projects in the ASWF (https://github.com/AcademySoftwareFoundation/MaterialX, https://github.com/AcademySoftwareFoundation/openexr, AcademySoftwareFoundation/OpenImageIO#4428 for example).I'm leaving this PR as a draft because there are some failures on Python 3.7 and I'm not too sure why.
TODO: