-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JavaScript bindings for element equivalence #2126
Merged
jstone-lucasfilm
merged 8 commits into
AcademySoftwareFoundation:main
from
kwokcb:js_equvalence_bindings
Dec 12, 2024
Merged
Add JavaScript bindings for element equivalence #2126
jstone-lucasfilm
merged 8 commits into
AcademySoftwareFoundation:main
from
kwokcb:js_equvalence_bindings
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwokcb
changed the title
Ad in Javascript bindings for equivalence API
Add in Javascript bindings for equivalence API
Nov 27, 2024
11 tasks
11 tasks
Simply the test to just test the JS wrapper logic
kwokcb
commented
Dec 11, 2024
jstone-lucasfilm
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, thanks @kwokcb!
jstone-lucasfilm
changed the title
Add in Javascript bindings for equivalence API
Add Javascript bindings for equivalence API
Dec 12, 2024
jstone-lucasfilm
changed the title
Add Javascript bindings for equivalence API
Add JavaScript bindings for element equivalence
Dec 12, 2024
jstone-lucasfilm
merged commit Dec 12, 2024
c46e8a3
into
AcademySoftwareFoundation:main
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Element::isEquivalent()
+ options structure API in Javascript.Tests