Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JavaScript bindings for element equivalence #2126

Merged

Conversation

kwokcb
Copy link
Contributor

@kwokcb kwokcb commented Nov 27, 2024

Change

  • Expose the Element::isEquivalent() + options structure API in Javascript.

Tests

  • New unit test was added which performs a basic error check.

@kwokcb kwokcb changed the title Ad in Javascript bindings for equivalence API Add in Javascript bindings for equivalence API Nov 27, 2024
Simply the test to just test the JS wrapper logic
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, thanks @kwokcb!

@jstone-lucasfilm jstone-lucasfilm changed the title Add in Javascript bindings for equivalence API Add Javascript bindings for equivalence API Dec 12, 2024
@jstone-lucasfilm jstone-lucasfilm changed the title Add Javascript bindings for equivalence API Add JavaScript bindings for element equivalence Dec 12, 2024
@jstone-lucasfilm jstone-lucasfilm merged commit c46e8a3 into AcademySoftwareFoundation:main Dec 12, 2024
34 checks passed
@kwokcb kwokcb deleted the js_equvalence_bindings branch December 13, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants