Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom MDL nodes #2125

Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
7bec607
initial commit
krohmerNV Nov 14, 2024
abd69f2
added support for multiple output nodes and some tests
krohmerNV Nov 14, 2024
ec4a348
added tests for nodes with texture filename inputs
krohmerNV Nov 15, 2024
932a330
added support tests cases for MDL language version numbering on custo…
krohmerNV Nov 15, 2024
2a3c943
fix reference pointed out by clang/gcc warning
krohmerNV Nov 18, 2024
0f94a0c
do not test custom nodes on backends other than MDL
krohmerNV Nov 18, 2024
54fbc59
remove floating point suffix in mtlx files
krohmerNV Nov 18, 2024
227b9d6
remove floating point suffix in mtlx files 2
krohmerNV Nov 18, 2024
81de708
initial commit for inline source code nodes
krohmerNV Nov 26, 2024
2073198
handle reserved words for inline sourcecode
krohmerNV Nov 27, 2024
8c1677b
cleaned up the mtl_ prefixes for input and output names
krohmerNV Nov 27, 2024
cacd91b
added an example procedural and catched to cases of invalid input
krohmerNV Nov 28, 2024
77ad9c2
remove test changes and new test content to be split out into another PR
krohmerNV Dec 10, 2024
447f225
Omit gitignore update for now
jstone-lucasfilm Dec 11, 2024
59b428f
Remove extra newline
jstone-lucasfilm Dec 11, 2024
ec8bc68
Remove extra newline
jstone-lucasfilm Dec 11, 2024
3c84f50
Update letter case
jstone-lucasfilm Dec 11, 2024
01b4c78
Consolidate namespaces
jstone-lucasfilm Dec 11, 2024
e831616
Minor spelling fix
jstone-lucasfilm Dec 11, 2024
44de304
Update letter case
jstone-lucasfilm Dec 11, 2024
0e3c390
Merge branch 'main' into krohmer/custom_mdl_nodes
jstone-lucasfilm Dec 11, 2024
c0741c3
Remove duplicate include
jstone-lucasfilm Dec 11, 2024
db8a230
Adjust comment type
jstone-lucasfilm Dec 11, 2024
dc164d8
Merge branch 'main' into krohmer/custom_mdl_nodes
jstone-lucasfilm Dec 12, 2024
bfebfb9
Letter case updates
jstone-lucasfilm Dec 12, 2024
4c22051
Letter case updates
jstone-lucasfilm Dec 12, 2024
456470e
Update MdlSyntax.cpp
krohmerNV Dec 12, 2024
f01da2b
Extend update to header
jstone-lucasfilm Dec 12, 2024
79bcf72
Align comments for Doxygen
jstone-lucasfilm Dec 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update MdlSyntax.cpp
pass string parameter by reference

Signed-off-by: krohmerNV <42233792+krohmerNV@users.noreply.github.com>
  • Loading branch information
krohmerNV authored Dec 12, 2024
commit 456470e322d9e3917d678b9a1e260f4608a5072c
2 changes: 1 addition & 1 deletion source/MaterialXGenMdl/MdlSyntax.cpp
Original file line number Diff line number Diff line change
@@ -555,7 +555,7 @@ void MdlSyntax::makeValidName(string& name) const
}
}

string MdlSyntax::modifyPortName(const string word) const
string MdlSyntax::modifyPortName(const string& word) const
{
return PORT_NAME_PREFIX + word;
}