Fix handling of missing scenes in the Web Viewer #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samip
force-pushed
the
fix_js_viewer_missing_model_handling
branch
from
bc78e8b to
47a1663
Compare
JsViewerX attempted to use a cube when the selected GLTF file contained no model, but the code never added it to the scene.
samip
force-pushed
the
fix_js_viewer_missing_model_handling
branch
from
47a1663 to
f223348
Compare
|
This looks very promising, @samip! You should be able to resolve the EasyCLA issue by clicking on one of the two links in the Linux Foundation comment above, and let us know if you need additional assistance. |
kwokcb
reviewed
Dec 4, 2024
jstone-lucasfilm
approved these changes
Dec 4, 2024
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit bf2804d
into
AcademySoftwareFoundation:main
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsViewerX attempted to use a cube when the selected GLTF file contained no model, but the code never added it to the scene.