Update UsdPreviewSurface to version 2.6 #2084
Open
+22
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oundation#2044. It also updates the nodegraph to reflect the recently updated PreviewSurface v2.5 which removes specular highlights for fully transparent materials.
A recent change updated the nodegraph to reflect the updated PreviewSurface v2.5, which removes specular highlights for fully transparent materials. This change makes it such that opacity = 0 is treated the same regardless of if we use the transmissionOpacity or transmissionRefraction options, or if the material is in cutout or transparency mode.
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
This change maintains the current behavior when using 'transmissiveRefraction' method, while also keeping the opacity = 0 behavior consistent between the `transmissiveOpacity` and `transmissiveRefraction` methods.
klucknav
changed the title
jstone-lucasfilm
changed the title
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
This change restores usd_preview_surface_glass.mtlx to its original form, as these updates to UsdPreviewSurface should be fully backwards-compatible. Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
|
This looks excellent, thanks @klucknav! For consistency, should we add the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the PreviewSurface Nodegraph to address the opacity issue in cutout mode described in gitIssue #2044. It also updates the nodegraph to reflect the recently updated PreviewSurface v2.6 spec which states that fully transparent materials do not have a lighting response. Since the preview surface glass example was fully transparent, it is also updated to have a very slight opacity value.