-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Windows DLL search path for Python 3.8+ #1440
Adjust Windows DLL search path for Python 3.8+ #1440
Conversation
Signed-off-by: JGamache-autodesk <56274617+JGamache-autodesk@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the long delay on this, @JGamache-autodesk, and I wanted to follow up to see whether this pull request should move forward.
From our latest vantage point in December 2024, is this still the recommended workaround for Python versions >= 3.8 on Windows?
You will find out other similar versions of this code in USD,and many ASWF projects in either the Python install or the Python test suite. We do add extra checks, as requested, because when installed as a Python module, the libraries end up in the folder when Python puts all libraries, which means they are already in the DLL load path. It is only when installing as a binary package that we require adding the path to the MaterialX libraries, for example, when MaterialX is packaged with USD. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks @JGamache-autodesk!
c174960
into
AcademySoftwareFoundation:main
Fixes #1439
Required by python/cpython#80266