Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Windows DLL search path for Python 3.8+ #1440

Conversation

JGamache-autodesk
Copy link
Contributor

Fixes #1439

Required by python/cpython#80266

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 4, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@JGamache-autodesk JGamache-autodesk deleted the adsk/bugfix/module_path_fix_python_3_8 branch August 4, 2023 15:45
@JGamache-autodesk JGamache-autodesk restored the adsk/bugfix/module_path_fix_python_3_8 branch August 4, 2023 15:45
@JGamache-autodesk JGamache-autodesk deleted the adsk/bugfix/module_path_fix_python_3_8 branch August 4, 2023 15:47
@JGamache-autodesk JGamache-autodesk restored the adsk/bugfix/module_path_fix_python_3_8 branch August 4, 2023 17:51
JGamache-autodesk and others added 3 commits October 25, 2023 12:16
Signed-off-by: JGamache-autodesk <56274617+JGamache-autodesk@users.noreply.github.com>
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the long delay on this, @JGamache-autodesk, and I wanted to follow up to see whether this pull request should move forward.

From our latest vantage point in December 2024, is this still the recommended workaround for Python versions >= 3.8 on Windows?

python/MaterialX/__init__.py Show resolved Hide resolved
@JGamache-autodesk
Copy link
Contributor Author

You will find out other similar versions of this code in USD,and many ASWF projects in either the Python install or the Python test suite.

We do add extra checks, as requested, because when installed as a Python module, the libraries end up in the folder when Python puts all libraries, which means they are already in the DLL load path. It is only when installing as a binary package that we require adding the path to the MaterialX libraries, for example, when MaterialX is packaged with USD.

Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @JGamache-autodesk!

@jstone-lucasfilm jstone-lucasfilm merged commit c174960 into AcademySoftwareFoundation:main Dec 13, 2024
34 checks passed
@JGamache-autodesk JGamache-autodesk deleted the adsk/bugfix/module_path_fix_python_3_8 branch December 13, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python bindings not working on Windows with Python 3.8+
3 participants