Add null checks to UiPin methods

This changelist adds null checks to the UiPin::addConnection and UiPin::deleteConnection methods in the Graph Editor, providing additional protection against crashes.
AcademySoftwareFoundation · Dec 15, 2024 · a1bf6e6 · a1bf6e6
1 parent d4ee66c
commit a1bf6e6
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/source/MaterialXGraphEditor/UiNode.h b/source/MaterialXGraphEditor/UiNode.h
@@ -85,6 +85,11 @@ class UiPin
 
     void addConnection(UiPinPtr pin)
     {
+        if (!pin)
+        {
+            return;
+        }
+
         for (size_t i = 0; i < _connections.size(); i++)
         {
             if (_connections[i]->_pinId == pin->_pinId)
@@ -97,6 +102,11 @@ class UiPin
 
     void deleteConnection(UiPinPtr pin)
     {
+        if (!pin)
+        {
+            return;
+        }
+
         for (size_t i = 0; i < _connections.size(); i++)
         {
             if (_connections[i]->_pinId == pin->_pinId)
@@ -115,7 +125,6 @@ class UiPin
         {
             pin->setConnected(false);
         }
-        return;
     }
 
     const std::vector<UiPinPtr>& getConnections()