Skip to content

Commit

Permalink
Simplify shader generator exclusions
Browse files Browse the repository at this point in the history
This changelist simplifies the shader generator exclusion lists used in unit testing, removing legacy exclusions that are no longer needed with the current data libraries.
  • Loading branch information
jstone-lucasfilm committed Dec 10, 2024
1 parent bc2466e commit 8e68b78
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 13 deletions.
7 changes: 3 additions & 4 deletions source/MaterialXTest/MaterialXGenGlsl/GenGlsl.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,9 @@ class GlslShaderGeneratorTester : public GenShaderUtil::ShaderGeneratorTester
{
whiteList =
{
"screen", "displacementshader", "volumeshader",
"IM_constant_", "IM_dot_", "IM_geompropvalue_boolean", "IM_geompropvalue_string",
"IM_light_genglsl", "IM_point_light_genglsl", "IM_spot_light_genglsl", "IM_directional_light_genglsl",
"IM_angle", "volumematerial", "ND_volumematerial"
"volumeshader", "volumematerial",
"IM_constant_", "IM_dot_", "IM_angle", "IM_geompropvalue_boolean", "IM_geompropvalue_string",
"IM_light_", "IM_point_light_", "IM_spot_light_", "IM_directional_light_"
};
ShaderGeneratorTester::getImplementationWhiteList(whiteList);
}
Expand Down
5 changes: 2 additions & 3 deletions source/MaterialXTest/MaterialXGenMdl/GenMdl.h
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,8 @@ class MdlShaderGeneratorTester : public GenShaderUtil::ShaderGeneratorTester
{
whiteList =
{
"backfacing", "screen", "displacementshader",
"volumeshader", "IM_constant_", "IM_dot_", "IM_geomattrvalue", "IM_angle",
"geompropvalue", "surfacematerial", "volumematerial",
"displacementshader", "volumeshader", "surfacematerial", "volumematerial", "geompropvalue",
"IM_constant_", "IM_dot_", "IM_angle", "IM_geomattrvalue",
"IM_absorption_vdf_", "IM_mix_vdf_", "IM_add_vdf_", "IM_multiply_vdf",
"IM_measured_edf_", "IM_blackbody_", "IM_conical_edf_",
"IM_displacement_", "IM_volume_", "IM_light_"
Expand Down
8 changes: 4 additions & 4 deletions source/MaterialXTest/MaterialXGenMsl/GenMsl.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ class MslShaderGeneratorTester : public GenShaderUtil::ShaderGeneratorTester
{
whiteList =
{
"backfacing", "screen", "displacementshader",
"volumeshader", "IM_constant_", "IM_dot_", "IM_geompropvalue_boolean", "IM_geompropvalue_string",
"IM_light_genmsl", "IM_point_light_genmsl", "IM_spot_light_genmsl", "IM_directional_light_genmsl",
"IM_angle", "surfacematerial", "volumematerial", "ND_surfacematerial", "ND_volumematerial", "ND_backface_util", "IM_backface_util_genmsl"
"displacementshader", "volumeshader", "surfacematerial", "volumematerial",
"IM_constant_", "IM_dot_", "IM_angle", "IM_geompropvalue_boolean", "IM_geompropvalue_string",
"IM_light_", "IM_point_light_", "IM_spot_light_", "IM_directional_light_",
"ND_surfacematerial", "ND_volumematerial"
};
}
};
Expand Down
4 changes: 2 additions & 2 deletions source/MaterialXTest/MaterialXGenOsl/GenOsl.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ class OslShaderGeneratorTester : public GenShaderUtil::ShaderGeneratorTester
{
whiteList =
{
"backfacing", "screen", "displacementshader",
"volumeshader", "IM_constant_", "IM_dot_", "IM_geompropvalue", "IM_angle", "ND_backface_util"
"displacementshader", "volumeshader",
"IM_constant_", "IM_dot_", "IM_angle", "IM_geompropvalue"
};
ShaderGeneratorTester::getImplementationWhiteList(whiteList);
}
Expand Down

0 comments on commit 8e68b78

Please sign in to comment.