Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure disable.count.query = true does not change the behavior of ingestion #539

Open
yruslan opened this issue Jan 13, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@yruslan
Copy link
Collaborator

yruslan commented Jan 13, 2025

Background

Currently, when

disable.count.query = true

a table is considered successfully loaded even if it does not have data for the current date. This is because the count check is skipped.

Feature

Make sure disable.count.query = true does not change the behavior of ingestion.

Example [Optional]

--

Proposed Solution [Optional]

The correct behavior is the same as the one when disable.count.query = false. If the number of records is 0 and empty tables are considered 'no data', the the record of data should not be written to the bookkeeping table.

@yruslan yruslan added the enhancement New feature or request label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant