Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#47 - Introduce Workflow to check presence of Release notes in PR body #48

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

#47 - Introduce Workflow to check presence of Release notes in PR body #48

wants to merge 5 commits into from
+256 −6

Conversation

miroslavpojer
Copy link
Collaborator

@miroslavpojer miroslavpojer commented Oct 17, 2024 •
edited by benedeki
Loading

  • Added workflow file to check presence of RLS notes in PR body.

Closes #47

@miroslavpojer
#47 - Introduce Workflow to check presence of Release notes in PR body
0a01291 
- Added workflow file to check presence of RLS notes in PR body.
@miroslavpojer miroslavpojer self-assigned this Oct 17, 2024
@github-actions GitHub Actions
Copy link

JaCoCo 'balta' module code coverage report - scala 2.12.18

Overall Project 46% 🍏

There is no coverage information present for the Files changed

@miroslavpojer miroslavpojer removed the request for review from benedeki October 17, 2024 07:42
@miroslavpojer miroslavpojer added the enhancement New feature or request label Oct 17, 2024
@benedeki benedeki self-requested a review October 18, 2024 05:57
miroslavpojer and others added 2 commits October 18, 2024 09:59
@miroslavpojer
- Implementation of review comment suggestions.
2f195e9
@benedeki
* fix on the action
c220bb2 
* release_draft.yml workflow added
* release_publish.yml changed to happen automatically on release
@benedeki benedeki added the no RN No release notes required label Oct 18, 2024
@benedeki
Copy link
Contributor

@miroslavpojer IMHO having release notes on a repository/automation change is pointless 😉

@miroslavpojer
Copy link
Collaborator Author

Yes. But here they are used for test of pr check implementation

benedeki
benedeki approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@benedeki benedeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release-notes check finally working. Other were taken from elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benedeki benedeki benedeki approved these changes

@lsulak lsulak Awaiting requested review from lsulak lsulak is a code owner

@salamonpavel salamonpavel Awaiting requested review from salamonpavel salamonpavel is a code owner

Assignees

@miroslavpojer miroslavpojer

Labels
enhancement New feature or request no RN No release notes required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Workflow to check presence of Release notes in PR body
2 participants
@miroslavpojer @benedeki