#43: DBTestSuite: parametrize persist_data into constructor #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make it easy to override data persitence in the `DBTestSuite` class, without the need to override functions.
benedeki
requested review from
miroslavpojer,
lsulak and
salamonpavel
as code owners
JaCoCo 'balta' module code coverage report - scala 2.12.18
|
| @@ -44,7 +48,9 @@ abstract class DBTestSuite extends AnyFunSuite { | |||
| /** | |||
| * This is the connection info for the DB. It can be overridden in the derived classes to provide specific credentials | |||
| */ | |||
| protected lazy val connectionInfo: ConnectionInfo = readConnectionInfoFromConfig | |||
| protected lazy val connectionInfo: ConnectionInfo = { | |||
There was a problem hiding this comment.
By this change, you kept the private method readConnectionInfoFromConfig without usage. Is that intention?
There was a problem hiding this comment.
Thanks for noticing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBTestSuiteclass, without the need to override functions.Closes #43
Release notes:
DBTestSuiteinstance via constructor parameter (no need to function overrides)