Add player stream #182
Open
Add player stream #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate `PlayerData` class to avoid redundancies. Fix auth issues for subsequent `SignIn` calls. Fix false positives for `isSignedIn`. Remove redundant channel methods for info accessible via `PlayerData` class & player stream.
|
Also working on an updated written tutorial to link to. I will push to this PR tonight or tomorrow. |
|
@Abedalkareem This PR still does not set the GameKit auth handler until The difference being that on iOS, This would adhere to Apple's guidelines, but would eliminate the ability for devs to defer sign-in to a later point in the app lifecycle (a possibility that no longer exists on Android either). |
theLee3
force-pushed
the
add-player-stream
branch
from
3221d98 to
aea47f8
Compare
theLee3
force-pushed
the
add-player-stream
branch
from
523348c to
b9b63f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds the getter
Stream<PlayerData?> playertoGameAuth, making it far easier to update the UI on auth changes.Issues related to
signInare also resolved, in particular, the hanging ofsignInon iOS due to setting theauthenticationHandleron everysignIncall. Per the docs, this should be set one time. Afterwards an error is thrown so the dev can direct the user to sign in via Game Center in the device settings.On Android, if Play Services is missing or outdated on the device,
signInwill no longer hang until the user taps the notification from Play Services. Many users did not notice this notification and perceived the app as frozen. Now the plugin will throw an error from thesignInmethod and, if possible, present a native dialog allowing the user to easily install or update Play Services on the device.PlayerDatanow includes all player related data for easy synchronous access from the stream.Some code has been refactored to utilize the data from stream to prevent redundant platform channel communications to optimize performance. All changes are fully backwards compatible.
Docs & changelog are updated accordingly, and version number is bumped to 4.1.0.