From d563faf5e0cb94c67092e08de157fe51152e9964 Mon Sep 17 00:00:00 2001 From: Abdulrhmn Ghanem Date: Thu, 23 Jan 2025 14:50:04 +0000 Subject: [PATCH] Fix broken tests for wrap_mpi2_pi2 --- src/angle.jl | 2 +- test/test-angle-test.jl | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/angle.jl b/src/angle.jl index dd93303..ec71b30 100644 --- a/src/angle.jl +++ b/src/angle.jl @@ -25,7 +25,7 @@ function wrap_0_pi(θ) end function wrap_mpi2_pi2(θ) - n = θ / 2π + n = 2θ / π n = trunc.(Int, n) y = ifelse.(mod.(n, 2) .== 0, θ - n * π, n * π - θ) return length(y) == 1 ? y[1] : y diff --git a/test/test-angle-test.jl b/test/test-angle-test.jl index bff7998..46e9b1b 100644 --- a/test/test-angle-test.jl +++ b/test/test-angle-test.jl @@ -32,10 +32,10 @@ end @test wrap_mpi2_pi2(0) ≈ 0 @test wrap_mpi2_pi2(-0.5 * π) ≈ -0.5 * π @test wrap_mpi2_pi2(0.5 * π) ≈ 0.5 * π - @test_broken wrap_mpi2_pi2(0.6 * π) ≈ 0.4 * π - @test_broken wrap_mpi2_pi2(-0.6 * π) ≈ -0.4 * π - @test_broken wrap_mpi2_pi2([0, -0.5 * π, 0.5 * π, 0.6 * π, -0.6 * π]) ≈ - [0, -0.5 * π, 0.5 * π, 0.4 * π, -0.4 * π] + @test wrap_mpi2_pi2(0.6 * π) ≈ 0.4 * π + @test wrap_mpi2_pi2(-0.6 * π) ≈ -0.4 * π + @test wrap_mpi2_pi2([0, -0.5 * π, 0.5 * π, 0.6 * π, -0.6 * π]) ≈ + [0, -0.5 * π, 0.5 * π, 0.4 * π, -0.4 * π] end @@ -51,8 +51,8 @@ end @test angle_wrap(-θ, mode = :zero22pi) ≈ wrap_0_2pi(-θ) @test angle_wrap(θ, mode = :zero2pi) ≈ wrap_0_pi(θ) @test angle_wrap(-θ, mode = :zero2pi) ≈ wrap_0_pi(-θ) - # @test_broken angle_wrap(θ, mode = :mpi22pi2) ≈ wrap_mpi2_pi2(θ) - # @test_broken angle_wrap(-θ, mode = :mpi22pi2) ≈ wrap_mpi2_pi2(-θ) + @test angle_wrap(θ, mode = :mpi22pi2) ≈ wrap_mpi2_pi2(θ) + @test angle_wrap(-θ, mode = :mpi22pi2) ≈ wrap_mpi2_pi2(-θ) @test_throws ArgumentError angle_wrap(θ, mode = :foo) end end