Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: note.tupletId gets out of sync with tuplet.id after deserialization #98

Merged

Conversation

strangarnenad
Copy link
Contributor

As the title says, note.tupletId gets out of sync with tuplet.id after deserialization. Since IDs are always regenerated, regardless of whether they are new or cloned, we need to ensure they remain in sync.

@AaronDavidNewman AaronDavidNewman merged commit 9a1ce0d into AaronDavidNewman:master Sep 21, 2024
1 check passed
@AaronDavidNewman
Copy link
Owner

@strangarnenad are you interested in contributing additional PRs to Smoosic? I'd like to add a general 'tuplet' dialog, and additional beaming enhancements. There will probably be no Earthly rewards :) But you already know the relevant code, and I appreciate your contributions.

@strangarnenad
Copy link
Contributor Author

Hi @AaronDavidNewman,
Oh yes, I plan to contribute to this project in the future as well. It's a hobby for me, so don't worry about the rewards :)
Should we start using the 'projects' section of the github to have at least a general overview what we will be working on?

@AaronDavidNewman
Copy link
Owner

Yes I am trying to understand projects. It is a bit more like work :) But I think I want to set up an Organization for Smoosic, and then invite people into it. Then create a project where people can take ownership of features.

@strangarnenad
Copy link
Contributor Author

Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants