Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test cases #69

Conversation

choaticman
Copy link

@choaticman choaticman commented Oct 15, 2024

Description

Closes Update test cases #68

Fixes most of the test files which are preventing compilation of code.

Changes made

Impact of changes

Testing Steps

@choaticman choaticman added the priority.High MUST DO!!! label Oct 15, 2024
@choaticman choaticman added this to the v1.3 milestone Oct 15, 2024
@choaticman choaticman self-assigned this Oct 15, 2024
@choaticman choaticman linked an issue Oct 15, 2024 that may be closed by this pull request
assertTrue(parser.parseCommand(ClearCommand.COMMAND_WORD) instanceof ClearCommand);
assertTrue(parser.parseCommand(ClearCommand.COMMAND_WORD + " 3") instanceof ClearCommand);
}
// Todo when CLEAR feature is implemented

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the clear feature has been implemented

public void contains_internshipWithSameIdentityFieldsInList_returnsTrue() {
uniqueList.add(GOOGLE);
InternshipApplication editedGoogle = new InternshipApplicationBuilder(GOOGLE)
.withName(VALID_COMPANYNAME_YAHOO)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be VALID_COMPANY_NAME_YAHOO instead with the extra underscore?

@Raghava-Chittidi Raghava-Chittidi merged commit 37530d3 into AY2425S1-CS2103T-W09-3:master Oct 16, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High MUST DO!!!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update test cases
2 participants