Modify find command #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes Find internship application feature #66
The previous find command is finding for persons instead of internship applications. Furthermore, it finds them by exact word match which may not be useful. This PR modifies the find command to search for internship applications whose company name contain the search prefix.
Changes made
Previously, the find command finds by exact word matches (case-insensitive). Now, it has been modified to find by search prefix (case-insensitive).
Testing Steps
Only manual testing so far
FindCommandTest's automated tests have been updated accordingly. However, further modifications are required if we switch to searching by prefix.