Skip to content

Commit

Permalink
Merge pull request #226 from woke02/branch-kelly-fix-docs-bugs
Browse files Browse the repository at this point in the history
Fix Docs Bugs
  • Loading branch information
snowstopxt authored Nov 7, 2024
2 parents 4458e33 + 0949d41 commit cd4f27c
Show file tree
Hide file tree
Showing 8 changed files with 75 additions and 81 deletions.
2 changes: 1 addition & 1 deletion docs/AboutUs.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ You can reach us at the email `hireme@gmail.com`
[[portfolio](team/woke02.md)]

* Role: Developer
* Responsibilities: Dev Ops + Threading
* Responsibilities: Software Engineer

### Wu XueTing

Expand Down
72 changes: 36 additions & 36 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,7 @@ Priorities: High (must have) - `* * *`, Medium (nice to have) - `* *`, Low (unli
- **PENDING**: The internship application is currently in progress.
- **REJECTED**: The user has rejected or been rejected from this internship application.
- **ACCEPTED**: The user has accepted the offer for this internship.


- **Action**: The task carried out by the HireMe application such as Add, Delete, Update entries.

Expand Down Expand Up @@ -731,41 +731,41 @@ testers are expected to do more *exploratory* testing.
1. Opening Help window via Command Line

1. Prerequisite: Help window is not open.

2. Test case: `/help` <br>
Expected: Help window opens.

1. Opening Help window via `F1`

1. Prerequisite: Help window is not open.

2. Test case: Click the `F1` key on your keyboard. <br>
Expected: Help window opens.

1. Opening Help window via Tool Bar

1. Prerequisite: Help window is not open.

2. Test case: Click on the `Help` button on the Tool Bar, and then click on the `Help F1` button on the drop down.<br>
Expected: Help window opens.

1. Minimising the Help window

1. Prerequisite: Help window is not open.

2. Test case: `/help` <br>
Expected: Help window opens.
3. Test case: Click on the minimise buttn of the Help window.<br>

3. Test case: Click on the minimise button of the Help window.<br>
Expected: Help window minimises.

4. Test case: `/help` after the Help window is minimised.<br>
Expected: Help window does not pop open.

1. Closing the Help window

1. Prerequisite: Help window is open.

2. Test case: Click on the close button on the Help window. <br>
Expected: Help window closes.

Expand All @@ -787,45 +787,45 @@ testers are expected to do more *exploratory* testing.
1. Adding an valid internship application

1. Prerequisite: The exact internship application should not already be in the list.

2. Test case: `/add n/Google r/Software Engineer Intern e/google@gmail.com d/31/10/24`<br>
Expected: An internship application is successfully added, with the company name, company email, role and date of application being `Google`, `google@gmail.com`, `Software Engineer Intern`, `31/10/24`, respectively. The status of newly added internship application would be `Pending`.
Expected: An internship application is successfully added, with the company name, company email, role and date of application being `Google`, `google@gmail.com`, `Software Engineer Intern`, `31/10/24`, respectively. The status of newly added internship application would be `Pending`.

2. Adding another valid internship application

1. Prerequisite: The exact internship application should not already be in the list.

2. Test case: `/add n/Yahoo r/Clerk e/yahoo@yahoo.com d/31/10/24`<br>
Expected: An internship application is successfully added, with the company name, company email, role and date of application being `Yahoo`, `yahoo@yahoo.com`, `Clerk`, `31/10/24`, respectively. The status of newly added internship application would be `Pending`.

3. Adding duplicated internship application

1. Prerequisite: The exact internship application should already be in the list.

2. Test case: `/add n/Yahoo r/Clerk e/yahoo@yahoo.com d/31/10/24`<br>
Expected: An error message stating that the internship application already exists in the list.

4. Adding internship application with invalid fields

1. Missing/Invalid Company Name test case: `/add n/ r/Software Engineer Intern e/google@gmail.com d/31/10/24` <br>
Expected: An error message stating what is considered a valid Company Name.<br>

1. Other Invalid Company Names include: `<oding lab`, `|-|appy Days`, `@pple`.

2. Missing/Invalid Role test case: `/add n/Google r/ e/google@gmail.com d/31/10/24` <br>
Expected: An error message stating what is considered a valid Role.<br>

1. Other invalid Roles include: `Software_Engineer_Intern`, `Cl-erk`.

3. Missing/Invalid Email test case: `/add n/Google r/Software Engineer Intern e/ d/31/10/24`<br>
Expected: An error message stating what is considered a valid Email.

1. Other invalid Emails include: `@gmail.com`, `google.com`, `domainLabelTooShort@gmail.x`.

4. Missing/Invalid Date test case: `/add n/Google r/Software Engineer Intern e/google@gmail.com d/`<br>
Expected: An error message stating what is considered a valid Date.
1. Other invalid Dates include: Dates in the future (Relative to device's clock), `30/02/2024`, `31/04/2024`.
1. Other invalid Dates include: Dates in the future (Relative to device's clock), `30/02/2024`, `31/04/2024`.

5. Adding internship application with missing field(s)
1. Test case: `/add n/Google r/Software Engineer Intern e/google@gmail.com`<br>
Expected: An error message stating the valid use of the `/add` command.
Expand All @@ -836,7 +836,7 @@ testers are expected to do more *exploratory* testing.
1. Prerequisites: Ensure that the list is not empty. Reduce the view size of list by executing an arbitrary '\find' command. e.g. `\find a`.
2. Test case: `/list`<br>
Expected: The list should display all internship applications.

2. **List all internship applications with invalid command format**
1. Prerequisites: Ensure that the list is not empty. Reduce the view size of list by executing an arbitrary '\find' command. e.g. `\find a`.
2. Test case: `/list x`<br>
Expand Down Expand Up @@ -934,7 +934,7 @@ testers are expected to do more *exploratory* testing.

1. Prerequisites: List all internship applications using the `/list` command. Ensure that at least the "Google" and "Yahoo" applications exist.
2. Test case: `/reject 1`<br>
Expected: The status of the 1st application (e.g., "Google") is updated to `REJECTED`.
Expected: The status of the 1st application (e.g., "Google") is updated to `REJECTED`.
3. Test case: `/reject 0`<br>
Expected: An error message indicating that the index is invalid.

Expand All @@ -954,22 +954,22 @@ testers are expected to do more *exploratory* testing.
1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is are at least two internship applications with different statuses and the chart window is not opened.
2. Test case: `/chart x`<br>
Expected: An error message stating the valid use of the `/chart` command.

3. **Update chart window by updating status**
1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is are the internship application at index 1 is of `PENDING` status and the chart window is already opened.
2. Test case: `/accept 1`<br>
Expected: Pie chart on chart window to update accordingly.

4. **Update chart window by adding an internship application**
1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is at least one internship application, `Google` is not in list, and the chart window is already opened.
2. Test case: `/add n/Google r/Software Engineer Intern e/google@gmail.com d/31/10/24`<br>
Expected: Pie chart on chart window to update accordingly.

5. **Update chart window by deleting an internship application**
1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is at are at least two internship applications and the chart window is already opened.
2. Test case: `/delete 1`<br>
Expected: Pie chart on chart window to update accordingly.

6. **Close chart window**
1. Prerequisites: Chart window is already opened.
2. Test case: Click on the close button on the Help window. <br>
Expand All @@ -980,7 +980,7 @@ testers are expected to do more *exploratory* testing.
1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is at least one internship application with `PENDING` status.
2. Test case `/filter PENDING`<br>
Expected: The list of internship applications should only display entries with `PENDING` status.

2. **Filter with a valid status in mixed case**
1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is at least one internship application with `PENDING` status.
2. Test case `/filter Pending`
Expand All @@ -990,18 +990,18 @@ testers are expected to do more *exploratory* testing.
1. Prerequisites: Clear all internship applications using the `/clera` command.
2. Test case `/filter PENDING`
Expected: The list of internship applications remains empty.

4. **Filter with an invalid status**
1. Prerequisites: List all internship applications using the `/list` command. Ensure that the list is not empty.
2. Test case `/filter approved`
Expected: An error message indicating that the status is invalid.

5. **Filter with an empty status**
1. Prerequisites: Clear all internship applications using the `/list` command. Ensure that the list is not empty.
2. Test case `/filter `
Expected: An error message indicating that the status is invalid.


[//]: # (Delete section here)


Expand All @@ -1017,7 +1017,7 @@ testers are expected to do more *exploratory* testing.
1. Shutdown via Window's close button
1. Close the window by clicking on the Window's close button.<br>
Expected: The window should close.

2. Shutdown via Command Line
1. Type `/exit` to close the window.<br>
Expected: The window should close.
4 changes: 2 additions & 2 deletions docs/UserGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

HireMe is a **free desktop application that helps you manage your extensive list of internship applications.**

* [Easy to use]
* [Easy to use]
- Type simple commands: If you can type fast, HireMe can get your internship tracking tasks done faster than traditional apps.
* [High quality]
- User friendly interface: sleek list design to view all of your of internship applications.
* [Streamlining management]
* [Streamlining management]
- Add, delete and update your internship applications: everything you need to manage your list of internship applications.
* [Insights]
- Tailored summary of your list of internship applications so that you can gain hidden insights.
Expand Down
8 changes: 4 additions & 4 deletions docs/diagrams/StatusActivityDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -3,27 +3,27 @@
skinparam ArrowFontStyle plain

start
:User wants to update the status of the internship application at index i;
:User wants to update the status of the internship application at index i (where i is an integer);

switch ()
case ([User enters the command "/accept i"])
if ( ) then ([Index is valid])
if () then ([Index is valid])
:Update the internship application status to
**ACCEPTED**;
else ([else])
:User receives an error message;
stop
endif
case ([User enters the command "/reject i"])
if ( ) then ([Index is valid])
if () then ([Index is valid])
:Update the internship application status to
**REJECTED**;
else ([else])
:User receives an error message;
stop
endif
case ([User enters the command "/pending i"])
if ( ) then ([Index is valid])
if () then ([Index is valid])
:Update the internship application status to
**PENDING**;
else ([else])
Expand Down
2 changes: 1 addition & 1 deletion docs/team/raghava-chittidi.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Given below are my contributions to the project.
* Managed release `v1.4` (1 release) on GitHub

* **Enhancements to existing features**:
* Added defensive programming through the use of assertions and exceptions.
* Added defensive programming through the use of assertions and exceptions.
* Added logging to enable better debugging in the future.
* Ensured error messages are consistent for all commands to reduce ambiguity.

Expand Down
58 changes: 26 additions & 32 deletions docs/team/woke02.md
Original file line number Diff line number Diff line change
@@ -1,46 +1,40 @@
---
layout: default.md
title: "John Doe's Project Portfolio Page"
layout: default.md
title: "Kelly Wong's Project Portfolio Page"
---

### Project: AddressBook Level 3
### Project: HireMe

AddressBook - Level 3 is a desktop address book application used for teaching Software Engineering principles. The user interacts with it using a CLI, and it has a GUI created with JavaFX. It is written in Java, and has about 10 kLoC.
HireMe is a **desktop application for managing internship applications, optimized for use via a Command Line Interface** (CLI) while still having the benefits of a Graphical User Interface (GUI). If you can type fast, HireMe can help you manage your internship tracking tasks faster than traditional GUI apps.

Given below are my contributions to the project.

* **New Feature**: Added the ability to undo/redo previous commands.
* What it does: allows the user to undo all previous commands one at a time. Preceding undo commands can be reversed by using the redo command.
* Justification: This feature improves the product significantly because a user can make mistakes in commands and the app should provide a convenient way to rectify them.
* Highlights: This enhancement affects existing commands and commands to be added in future. It required an in-depth analysis of design alternatives. The implementation too was challenging as it required changes to existing commands.
* Credits: *{mention here if you reused any code/ideas from elsewhere or if a third-party library is heavily used in the feature so that a reader can make a more accurate judgement of how much effort went into the feature}*
* **New Feature**: Architected and implemented a robust model schema, creating foundational model classes essential for application functionality.
* Details: Developed critical model classes, including `Company`, `Date`, `Email`, `InternshipApplication`, `Name`, `Role`, and `Status`, which serve as the building blocks for the entire model structure.
* Justification: These classes establish a scalable, clear, and maintainable framework, streamlining data flow and ensuring efficient data management across the application. This structured approach optimizes performance and paves the way for future feature expansion with minimal refactoring.

* **New Feature**: Added a history command that allows the user to navigate to previous commands using up/down keys.

* **Code contributed**: [RepoSense link]()
* **New Feature**: Added a status command to update the status of an internship application.
* What it does: Allows users to update the status of an internship application to `ACCEPTED`, `PENDING`, or `REJECTED`.
* Justification: This feature is crucial for tracking the current stage of each application, enabling users to keep organized records.

* **Project management**:
* Managed releases `v1.3` - `v1.5rc` (3 releases) on GitHub
* Managed releases `v1.3` and `v1.5` on GitHub, overseeing feature completeness and stability.

* **Enhancements to existing features**:
* Updated the GUI color scheme (Pull requests [\#33](), [\#34]())
* Wrote additional tests for existing features to increase coverage from 88% to 92% (Pull requests [\#36](), [\#38]())
* Added logging to improve future debugging processes.
* Ensured error messages are consistent across models to reduce ambiguity.
* Enhanced defensive programming by using assertions and exceptions for increased robustness.

* **Testing**:
* Added extensive test cases for the models and certain parser commands to ensure code reliability.

* **Documentation**:
* User Guide:
* Added documentation for the features `delete` and `find` [\#72]()
* Did cosmetic tweaks to existing documentation of features `clear`, `exit`: [\#74]()
* Developer Guide:
* Added implementation details of the `delete` feature.

* **Community**:
* PRs reviewed (with non-trivial review comments): [\#12](), [\#32](), [\#19](), [\#42]()
* Contributed to forum discussions (examples: [1](), [2](), [3](), [4]())
* Reported bugs and suggestions for other teams in the class (examples: [1](), [2](), [3]())
* Some parts of the history feature I added was adopted by several other class mates ([1](), [2]())

* **Tools**:
* Integrated a third party library (Natty) to the project ([\#42]())
* Integrated a new Github plugin (CircleCI) to the team repo

* _{you can add/remove categories in the list above}_
* **User Guide**:
* Documented the `help`, `status`, `clear`, and `exit` features.
* Provided instructions on how to download and run the app.
* **Developer Guide**:
* Added implementation details for the `status` feature.
* Created sequence diagrams for `status` features.
* Added user stories for the `find` and `status` features.
* Added use cases for the `find` and `status` features.
* Created an activity diagram for the `status` feature.
8 changes: 4 additions & 4 deletions docs/team/xueting.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ Given below are my contributions to the project.

* **New Feature**: Filter through all internship applications by status.
* What it does: Allows the user to filter through all internship applications by status of pending, accepted or rejected.
* Justification: This feature is nice-to-have as it allows users to easily find a group of internship application of specified status.
* Justification: This feature is nice-to-have as it allows users to easily find a group of internship application of specified status.



* **Code contributed**: [RepoSense link](https://nus-cs2103-ay2425s1.github.io/tp-dashboard/?search=&sort=totalCommits%20dsc&sortWithin=title&timeframe=commit&mergegroup=&groupSelect=groupByRepos&breakdown=true&checkedFileTypes=docs~functional-code~test-code~other&since=2024-09-20&tabOpen=true&tabType=authorship&tabAuthor=snowstopxt&tabRepo=AY2425S1-CS2103T-W09-3%2Ftp%5Bmaster%5D&authorshipIsMergeGroup=false&authorshipFileTypes=docs~functional-code~test-code~other&authorshipIsBinaryFileTypeChecked=false&authorshipIsIgnoredFilesChecked=false)

* **Project management**:
* Added labels to repository to use in PRs and Issues.
* Added labels to repository to use in PRs and Issues.
* Wrote meeting minutes for weekly meetings in internal project notes.

* **Enhancements to existing features**:
Expand All @@ -36,14 +36,14 @@ Given below are my contributions to the project.
* User Guide:
* Added documentation for the features `filter` and `list` (Pull request [\#126](https://github.com/AY2425S1-CS2103T-W09-3/tp/pull/126/files))
* Improved introduction section and added table of contents (Pull request [\#200](https://github.com/AY2425S1-CS2103T-W09-3/tp/pull/200))

* Developer Guide:
* Added implementation details and sequence diagram of the `filter` feature (Pull request [\#126](https://github.com/AY2425S1-CS2103T-W09-3/tp/pull/126/files))
* Tweak sequence diagram to storage (Pull request [\#126](https://github.com/AY2425S1-CS2103T-W09-3/tp/pull/126/files))
* Added table of contents to introduction section (Pull request [\#200](https://github.com/AY2425S1-CS2103T-W09-3/tp/pull/200))
* Added use cases for exit
* Added index to glossary


* **Community**:
* PRs reviewed (with non-trivial review comments): [\#103](https://github.com/AY2425S1-CS2103T-W09-3/tp/pull/103), [\#115](https://github.com/AY2425S1-CS2103T-W09-3/tp/pull/115), [\#135](https://github.com/AY2425S1-CS2103T-W09-3/tp/pull/135), [\#181](https://github.com/AY2425S1-CS2103T-W09-3/tp/pull/181)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public class Role {
* The role should only contain alphanumeric characters, spaces, and forward slashes (/),
* and it should not be blank.
*/
public static final String MESSAGE_CONSTRAINTS = "Role should only contain alphanumeric "
public static final String MESSAGE_CONSTRAINTS = "Roles should only contain alphanumeric "
+ "characters, spaces, and forward slashes (/), and it should not be blank.";
private final String value;

Expand Down

0 comments on commit cd4f27c

Please sign in to comment.