From 0486927df0f9eff05a958602be58ca20359d09da Mon Sep 17 00:00:00 2001 From: zwe Date: Tue, 12 Nov 2024 00:09:32 +0800 Subject: [PATCH 1/3] Fix phrasing --- docs/DeveloperGuide.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md index b58415c2e22..6d147908430 100644 --- a/docs/DeveloperGuide.md +++ b/docs/DeveloperGuide.md @@ -215,7 +215,7 @@ In this case, `AddressBookParser` creates `AddCommandParser` to parse user input If any of the above constraints are violated, `AddressBookParser` throws a ParseException. Otherwise, it creates a new instance of `AddCommand` that corresponds to the user input. `AddCommand` comprises of the internship application to be added, which is an instance of `InternshipApplication`. -Upon execution, `AddCommand` first queries the supplied model if it contains a duplicate internship application. If no duplicate internship application exists, `AddCommand` then adds the internship application into the data. +Upon execution, `AddCommand` first queries the supplied model if it contains a duplicate internship application. If no duplicate internship application exists, then `AddCommand` adds the internship application into the data.

@@ -349,7 +349,7 @@ The implementation of the command follows the convention of a normal command, wh `AddressBookParser` creates `ExitCommand` -Upon execution, `ExitCommand` gets encapsulates the intent to close the application in `CommandResult`. +Upon execution, `ExitCommand` encapsulates the intent to close the application in `CommandResult`. > **_NOTE:_** `Model` is not invoked here but included for the sake of clarity. From 03b5c3cbbadddc7217e6135dacb1776565a9319f Mon Sep 17 00:00:00 2001 From: zwe Date: Tue, 12 Nov 2024 00:30:14 +0800 Subject: [PATCH 2/3] Change help window to chart --- docs/DeveloperGuide.md | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md index 6d147908430..7dd442287e7 100644 --- a/docs/DeveloperGuide.md +++ b/docs/DeveloperGuide.md @@ -1029,46 +1029,46 @@ testers are expected to do more *exploratory* testing.

### Chart Window -1. Open chart window +1. Open Chart window - 1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is are at least two internship applications with different statuses and the chart window is not opened. + 1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is are at least two internship applications with different statuses and the Chart window is not opened. 2. Test case `/chart`
Expected: Chart window opens. -2. Open chart window with invalid command format +2. Open Chart window with invalid command format - 1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is are at least two internship applications with different statuses and the chart window is not opened. + 1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is are at least two internship applications with different statuses and the Chart window is not opened. 2. Test case: `/chart x`
Expected: An error message stating the valid use of the `/chart` command. -3. Update chart window by updating status +3. Update Chart window by updating status - 1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is are the internship application at index 1 is of `PENDING` status and the chart window is already opened. + 1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is are the internship application at index 1 is of `PENDING` status and the Chart window is already opened. 2. Test case: `/accept 1`
- Expected: Pie chart on chart window to update accordingly. + Expected: Pie chart on Chart window to update accordingly. -4. Update chart window by adding an internship application +4. Update Chart window by adding an internship application - 1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is at least one internship application, `Google` is not in list, and the chart window is already opened. + 1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is at least one internship application, `Google` is not in list, and the Chart window is already opened. 2. Test case: `/add n/Google r/Software Engineer Intern e/google@gmail.com d/31/10/24`
- Expected: Pie chart on chart window to update accordingly. + Expected: Pie chart on Chart window to update accordingly. -5. Update chart window by deleting an internship application +5. Update Chart window by deleting an internship application - 1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is at are at least two internship applications and the chart window is already opened. + 1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is at are at least two internship applications and the Chart window is already opened. 2. Test case: `/delete 1`
- Expected: Pie chart on chart window to update accordingly. + Expected: Pie chart on Chart window to update accordingly. -6. Close chart window +6. Close Chart window 1. Prerequisites: Chart window is already opened. - 2. Test case: Click on the close button on the Help window.
+ 2. Test case: Click on the close button on the Chart window.
Expected: Chart window closes.

From dd9a84cd51c25ca6f601331c73e95a52f2306b6a Mon Sep 17 00:00:00 2001 From: zwe Date: Tue, 12 Nov 2024 00:35:06 +0800 Subject: [PATCH 3/3] Add duplicate defn --- docs/DeveloperGuide.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md index 7dd442287e7..11511ee9647 100644 --- a/docs/DeveloperGuide.md +++ b/docs/DeveloperGuide.md @@ -217,6 +217,8 @@ In this case, `AddressBookParser` creates `AddCommandParser` to parse user input Upon execution, `AddCommand` first queries the supplied model if it contains a duplicate internship application. If no duplicate internship application exists, then `AddCommand` adds the internship application into the data. +> **_NOTE:_** HireMe identifies an entry as a duplicate if its `NAME`, `ROLE`, `EMAIL` and `DATE` match **(case-insensitive)** with those of an existing internship application entry. Attempting to add a duplicate will result in an error. +

### List all internship applications