Skip to content

Commit

Permalink
Merge pull request #341 from ZweZeya/branch-zwe-ped-fixes
Browse files Browse the repository at this point in the history
Minor DG Fixes
  • Loading branch information
Raghava-Chittidi authored Nov 11, 2024
2 parents e43ba25 + dd9a84c commit 3f7936c
Showing 1 changed file with 19 additions and 17 deletions.
36 changes: 19 additions & 17 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,9 @@ In this case, `AddressBookParser` creates `AddCommandParser` to parse user input
If any of the above constraints are violated, `AddressBookParser` throws a ParseException. Otherwise, it creates a new instance of `AddCommand` that corresponds to the user input.
`AddCommand` comprises of the internship application to be added, which is an instance of `InternshipApplication`.

Upon execution, `AddCommand` first queries the supplied model if it contains a duplicate internship application. If no duplicate internship application exists, `AddCommand` then adds the internship application into the data.
Upon execution, `AddCommand` first queries the supplied model if it contains a duplicate internship application. If no duplicate internship application exists, then `AddCommand` adds the internship application into the data.

> **_NOTE:_** HireMe identifies an entry as a duplicate if its `NAME`, `ROLE`, `EMAIL` and `DATE` match **(case-insensitive)** with those of an existing internship application entry. Attempting to add a duplicate will result in an error.
<br></br>

Expand Down Expand Up @@ -343,7 +345,7 @@ The implementation of the command follows the convention of a normal command, wh
<puml src="diagrams/ExitSequenceDiagram.puml" alt="ExitSequenceDiagram" />

`AddressBookParser` creates `ExitCommand`
Upon execution, `ExitCommand` gets encapsulates the intent to close the application in `CommandResult`.
Upon execution, `ExitCommand` encapsulates the intent to close the application in `CommandResult`.

> **_NOTE:_** `Model` is not invoked here but included for the sake of clarity.
Expand Down Expand Up @@ -1023,46 +1025,46 @@ testers are expected to do more *exploratory* testing.
<br></br>

### Chart Window
1. Open chart window
1. Open Chart window

1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is are at least two internship applications with different statuses and the chart window is not opened.
1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is are at least two internship applications with different statuses and the Chart window is not opened.

2. Test case `/chart`<br>
Expected: Chart window opens.

2. Open chart window with invalid command format
2. Open Chart window with invalid command format

1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is are at least two internship applications with different statuses and the chart window is not opened.
1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is are at least two internship applications with different statuses and the Chart window is not opened.

2. Test case: `/chart x`<br>
Expected: An error message stating the valid use of the `/chart` command.

3. Update chart window by updating status
3. Update Chart window by updating status

1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is are the internship application at index 1 is of `PENDING` status and the chart window is already opened.
1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is are the internship application at index 1 is of `PENDING` status and the Chart window is already opened.

2. Test case: `/accept 1`<br>
Expected: Pie chart on chart window to update accordingly.
Expected: Pie chart on Chart window to update accordingly.

4. Update chart window by adding an internship application
4. Update Chart window by adding an internship application

1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is at least one internship application, `Google` is not in list, and the chart window is already opened.
1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is at least one internship application, `Google` is not in list, and the Chart window is already opened.

2. Test case: `/add n/Google r/Software Engineer Intern e/google@gmail.com d/31/10/24`<br>
Expected: Pie chart on chart window to update accordingly.
Expected: Pie chart on Chart window to update accordingly.

5. Update chart window by deleting an internship application
5. Update Chart window by deleting an internship application

1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is at are at least two internship applications and the chart window is already opened.
1. Prerequisites: List all internship applications using the `/list` command. Ensure that there is at are at least two internship applications and the Chart window is already opened.

2. Test case: `/delete 1`<br>
Expected: Pie chart on chart window to update accordingly.
Expected: Pie chart on Chart window to update accordingly.

6. Close chart window
6. Close Chart window

1. Prerequisites: Chart window is already opened.

2. Test case: Click on the close button on the Help window. <br>
2. Test case: Click on the close button on the Chart window. <br>
Expected: Chart window closes.

<br></br>
Expand Down

0 comments on commit 3f7936c

Please sign in to comment.