Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need to set the sentry platform type? #73

Open
dave-shawley opened this issue Aug 31, 2022 · 0 comments
Open

Do we need to set the sentry platform type? #73

dave-shawley opened this issue Aug 31, 2022 · 0 comments

Comments

@dave-shawley
Copy link
Contributor

When we create a sentry project for an Imbi project we can set the "Platform" for the project. However, it is not clear that this is required since the language-specific SDK should be doing that for us. I've omitted setting the platform from the Sentry project creation code in the API for the time being. We can revisit this after we have some usage of the feature. If it is not necessary, then we should remove the related TODO in the code. If it is necessary, then we have to figure out how to determine what the platform is.
dave-shawley added a commit to dave-shawley/imbi-api that referenced this issue Aug 31, 2022
@dave-shawley
Stop setting the platform for Sentry projects
aa939f0 
We definitely don't want to hard code this to Python so the value will
have to be dynamically determined from some project fact.  However, I
think that the sentry client will overwrite this for us so I am going to
leave a TODO in there for the time being and create an issue to revisit
after we have some insight from actual usage.

AWeber-Imbi/imbi#73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dave-shawley