Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use base.require_permission consistently across endpoints #106

Open
in-op opened this issue Sep 10, 2024 · 0 comments
Open

Use base.require_permission consistently across endpoints #106

in-op opened this issue Sep 10, 2024 · 0 comments
Labels
api Issue relates to the API good first issue Good for newcomers low difficulty / effort

Comments

@in-op
Copy link
Contributor

in-op commented Sep 10, 2024 •
edited
Loading

We currently have two patterns for requiring admin permissions in the API, a base class of AdminCRUDRequestHandler, and a require_permission('admin') decorator. However, there are a number of endpoints (such as namespaces) using the AdminCRUDRequestHandler when GET should be accessible to everyone, as defined in the openapi spec. These should be standardized and match the required openapi spec.
@in-op in-op added good first issue Good for newcomers api Issue relates to the API low difficulty / effort labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Issue relates to the API good first issue Good for newcomers low difficulty / effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@in-op