Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #66: Rewarder composition #219

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Issue #66: Rewarder composition #219

wants to merge 1 commit into from

Conversation

Mark2000
Copy link
Contributor

@Mark2000 Mark2000 commented Dec 27, 2024 •
edited
Loading

Description

Closes #66

Allows for multiple rewarders to specified.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Tests added to cover multiple rewarders.

Future Work

May encounter some compatibility issues with complex rewarder setup, these have been noted with TODO comments.

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • If I changed an example ipynb, I have locally rebuilt the documentation

@Mark2000 Mark2000 force-pushed the feature/66-rewarder-composition branch from 4c9f51e to 5b436f7 Compare December 28, 2024 00:20
@Mark2000
Copy link
Contributor Author

Mark2000 commented Dec 30, 2024 •
edited
Loading

TODO: add release note

@Mark2000 Mark2000 force-pushed the feature/66-rewarder-composition branch from 5b436f7 to 719b0f3 Compare December 31, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhutererprats dhutererprats Awaiting requested review from dhutererprats

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for composition of data managers
1 participant
@Mark2000