Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug ad index mordred #390

Merged
merged 6 commits into from
Jan 30, 2025
Merged

Bug ad index mordred #390

merged 6 commits into from
Jan 30, 2025

Conversation

paulsonak
Copy link
Collaborator

to fix AD index calculation for mordred features #388

@paulsonak paulsonak requested a review from mcloughlin2 January 17, 2025 00:52
@paulsonak paulsonak changed the base branch from master to 1.7.0 January 17, 2025 00:53
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
atomsci/ddm/pipeline/model_pipeline.py 50.00% 3 Missing ⚠️
@@            Coverage Diff             @@
##            1.7.0     #390      +/-   ##
==========================================
+ Coverage   28.53%   30.57%   +2.03%     
==========================================
  Files          47       47              
  Lines       12919    13915     +996     
==========================================
+ Hits         3687     4254     +567     
- Misses       9232     9661     +429     
Files with missing lines Coverage Δ
atomsci/ddm/pipeline/model_pipeline.py 40.41% <50.00%> (-3.15%) ⬇️

... and 8 files with indirect coverage changes

@paulsonak paulsonak requested a review from mauvais2 January 17, 2025 21:19
@stewarthe6 stewarthe6 merged commit 65ec4da into 1.7.0 Jan 30, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants