New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cov module instead of folder path #374

Merged

mauvais2 merged 1 commit into ATOMScience-org:master from mass-matrix:mm/cov

Oct 1, 2024

Contributor

Kartstig commented Oct 1, 2024

I was able to verify the output by running the unit tests locally


          Use cov module instead of folder path

d0ac7a5

Kartstig commented

View reviewed changes

Makefile

@@ @@ -122,8 +122,8 @@ pytest-integrative: @@
               pytest-unit:
               	@echo "Running unit tests"
-              	docker run -v $(shell pwd)/$(WORK_DIR):/$(WORK_DIR) $(IMAGE_REPO):$(PLATFORM)-$(ENV) \
-              			/bin/bash -l -c "cd atomsci/ddm/test/unit && python3.9 -m pytest --capture=sys --capture=fd --cov=atomsci/ -vv"
+              	docker run -v $(shell pwd)/$(WORK_DIR):/$(WORK_DIR) $(IMAGE_REPO):$(TAG) \

Contributor Author

Kartstig Oct 1, 2024

I thought I had changed most of $(PLATFORM)-$(ENV) --> $(TAG) 🤔

mauvais2 approved these changes

View reviewed changes

mauvais2 merged commit 1116f36 into ATOMScience-org:master

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet