From 5907ce85e693d98d8d647d909b891a61645328df Mon Sep 17 00:00:00 2001 From: ARCANEDEV Date: Thu, 1 Sep 2016 16:59:58 +0100 Subject: [PATCH 1/5] Updating .gitattributes & .gitignore --- .gitattributes | 1 + .gitignore | 10 ++++------ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.gitattributes b/.gitattributes index 67da755..a1bf466 100644 --- a/.gitattributes +++ b/.gitattributes @@ -1,3 +1,4 @@ +/_docs export-ignore /tests export-ignore /.editorconfig export-ignore /.gitattributes export-ignore diff --git a/.gitignore b/.gitignore index 91836a3..8c59329 100644 --- a/.gitignore +++ b/.gitignore @@ -1,6 +1,4 @@ -.idea/ -_arcanedev/ -build/ -vendor/ -composer.phar -composer.lock +/build/ +/vendor/ +/composer.phar +/composer.lock From 40a809d29abef580b8be87b62ec7f7fe7f49343f Mon Sep 17 00:00:00 2001 From: ARCANEDEV Date: Thu, 1 Sep 2016 17:00:26 +0100 Subject: [PATCH 2/5] Updating Travis CI & Scrutinizer config files --- .scrutinizer.yml | 4 ++-- .travis.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.scrutinizer.yml b/.scrutinizer.yml index d55e956..71f6b05 100644 --- a/.scrutinizer.yml +++ b/.scrutinizer.yml @@ -20,8 +20,8 @@ checks: tools: external_code_coverage: - timeout: 600 - runs: 8 + timeout: 1200 + runs: 9 php_code_sniffer: enabled: true config: diff --git a/.travis.yml b/.travis.yml index 4ef332b..33c2196 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,10 +3,9 @@ language: php sudo: false php: - - 5.5.9 - - 5.5 - 5.6 - 7.0 + - 7.1 - nightly - hhvm @@ -17,6 +16,7 @@ matrix: env: - TESTBENCH_VERSION=3.1.* - TESTBENCH_VERSION=3.2.* + - TESTBENCH_VERSION=3.3.* before_script: - travis_retry composer self-update From 4af5c42735d3a7e78c38da76d82b6302d4af6749 Mon Sep 17 00:00:00 2001 From: ARCANEDEV Date: Thu, 1 Sep 2016 17:02:10 +0100 Subject: [PATCH 3/5] Updating config file --- config/sitemap.php | 32 ++++++++++++++++++++++++-------- 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/config/sitemap.php b/config/sitemap.php index 5033c5a..cb68075 100644 --- a/config/sitemap.php +++ b/config/sitemap.php @@ -1,7 +1,11 @@ [ + /* ------------------------------------------------------------------------------------------------ + | Cache + | ------------------------------------------------------------------------------------------------ + */ + 'cache' => [ 'enabled' => false, 'key' => 'laravel-sitemap.your-key', @@ -9,13 +13,25 @@ 'lifetime' => 3600, ], - 'escaping' => true, - - 'use-limit-size' => false, - - 'max-size' => null, - - 'styles' => [ + /* ------------------------------------------------------------------------------------------------ + | Escaping + | ------------------------------------------------------------------------------------------------ + */ + 'escaping' => true, + + /* ------------------------------------------------------------------------------------------------ + | Limit Size + | ------------------------------------------------------------------------------------------------ + */ + 'use-limit-size' => false, + + 'max-size' => null, + + /* ------------------------------------------------------------------------------------------------ + | Styles + | ------------------------------------------------------------------------------------------------ + */ + 'styles' => [ 'enabled' => true, 'location' => null, From 5b014af3d99b4145c05dbc08b12fc927859754e7 Mon Sep 17 00:00:00 2001 From: ARCANEDEV Date: Thu, 1 Sep 2016 17:02:35 +0100 Subject: [PATCH 4/5] Updating the views --- resources/views/google-news.blade.php | 10 ++++------ resources/views/ror-rdf.blade.php | 18 +++++++++--------- resources/views/ror-rss.blade.php | 2 +- resources/views/sitemapindex.blade.php | 4 ++-- resources/views/xml-mobile.blade.php | 16 ++++++++-------- resources/views/xml.blade.php | 4 ++-- 6 files changed, 26 insertions(+), 28 deletions(-) diff --git a/resources/views/google-news.blade.php b/resources/views/google-news.blade.php index e176429..ac0229c 100644 --- a/resources/views/google-news.blade.php +++ b/resources/views/google-news.blade.php @@ -1,12 +1,9 @@ - +'; ?> @if ($style) - + '; ?> @endif - + @foreach ($items as $item) - getGooglenews() ?> {{ $item->getLoc() }} @if ($item->getLastmod()) @@ -17,6 +14,7 @@ @endforeach @endif + getGooglenews() ?> {{ $googlenews['sitename'] }} diff --git a/resources/views/ror-rdf.blade.php b/resources/views/ror-rdf.blade.php index 1bd77e5..1da78ae 100644 --- a/resources/views/ror-rdf.blade.php +++ b/resources/views/ror-rdf.blade.php @@ -1,4 +1,4 @@ - +'; ?> {{ $channel['title'] }} @@ -6,13 +6,13 @@ sitemap @foreach ($items as $item) - - {{ $item->getLoc() }} - {{ $item->getTitle() }} - {{ $item->getLastmod() }} - {{ $item->getFreq() }} - {{ $item->getPriority() }} - - + + {{ $item->getLoc() }} + {{ $item->getTitle() }} + {{ $item->getLastmod() }} + {{ $item->getFreq() }} + {{ $item->getPriority() }} + + @endforeach diff --git a/resources/views/ror-rss.blade.php b/resources/views/ror-rss.blade.php index 34850a9..13ec101 100644 --- a/resources/views/ror-rss.blade.php +++ b/resources/views/ror-rss.blade.php @@ -1,4 +1,4 @@ - +'; ?> {{ $channel['title'] }} diff --git a/resources/views/sitemapindex.blade.php b/resources/views/sitemapindex.blade.php index 845a5b7..ee71647 100644 --- a/resources/views/sitemapindex.blade.php +++ b/resources/views/sitemapindex.blade.php @@ -1,6 +1,6 @@ - +'; ?> @if ($style) - + '; ?> @endif @foreach($sitemaps as $sitemap) diff --git a/resources/views/xml-mobile.blade.php b/resources/views/xml-mobile.blade.php index c258dde..aa4b26a 100644 --- a/resources/views/xml-mobile.blade.php +++ b/resources/views/xml-mobile.blade.php @@ -1,12 +1,12 @@ - +'; ?> @if ($style) - + '; ?> @endif -@foreach($items as $item) - - {{ $item->getLoc() }} - - -@endforeach + @foreach($items as $item) + + {{ $item->getLoc() }} + + + @endforeach diff --git a/resources/views/xml.blade.php b/resources/views/xml.blade.php index 2753419..46b0ddb 100644 --- a/resources/views/xml.blade.php +++ b/resources/views/xml.blade.php @@ -1,6 +1,6 @@ - +'; ?> @if ($style) - + '; ?> @endif @foreach ($items as $item) From b88037d87c83d8d780cd70dd38dc85b1d25fc432 Mon Sep 17 00:00:00 2001 From: ARCANEDEV Date: Thu, 1 Sep 2016 17:03:03 +0100 Subject: [PATCH 5/5] Updating README.md --- README.md | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 0ba02fd..370c582 100644 --- a/README.md +++ b/README.md @@ -15,6 +15,14 @@ This package is inspired/based on [RoumenDamianoff/laravel-sitemap](https://github.com/RoumenDamianoff/laravel-sitemap). +### Features + + * Easy setup & configuration. + * Well documented & IDE Friendly. + * Well tested with maximum code quality. + * Laravel `5.1 | 5.2 | 5.3` are supported. + * Made with :heart: & :coffee:. + ## Table of contents 1. [Requirements](_docs/1.Requirements.md) @@ -25,12 +33,7 @@ This package is inspired/based on [RoumenDamianoff/laravel-sitemap](https://gith ## TODOS - [ ] Documentation. - - [ ] 100% Code coverage + Maximum code quality. - - [ ] Laravel 5.3 support. - - [x] Laravel 5.2 support. - - [x] Laravel 5.1 support. - - [ ] Laravel 5.0 support. - - [x] Well documented package (IDE Friendly). + - [ ] 100% Code coverage. ## Contribution @@ -46,7 +49,7 @@ If you discover any security related issues, please email arcanedev.maroc@gmail. - [RoumenDamianoff/laravel-sitemap](https://github.com/RoumenDamianoff/laravel-sitemap) - [All Contributors][link-contributors] -[badge_laravel]: https://img.shields.io/badge/For-Laravel%205.x-orange.svg?style=flat-square +[badge_laravel]: https://img.shields.io/badge/Laravel-%205.1|5.2|5.3-orange.svg?style=flat-square [badge_license]: https://img.shields.io/packagist/l/arcanedev/laravel-sitemap.svg?style=flat-square [badge_build]: https://img.shields.io/travis/ARCANEDEV/LaravelSitemap.svg?style=flat-square [badge_hhvm]: https://img.shields.io/hhvm/arcanedev/laravel-sitemap.svg?style=flat-square