Convert relative refs when resolving an external schema #220
Conversation
Possibly corrects APIDevTools#200. This however causes tests to fail as they’re not expecting the references to be resolved. I’m not sure yet how to fix the tests. I thought I’d wait to see if the fix is valid!
…parser with our own versions In order to apply our patch for external references APIDevTools/json-schema-ref-parser#220
|
@karlvr hey I've poked a few people about trying to get a review, and hopefully it'll be more successful than when I tried 14 months ago. |
|
Bump |
|
Any update on this? We'd be happy to look at the tests and change them if needed but are not maintainers on the project. |
|
Hi there, can someone help to write tests for this feature? I've tested with There is a starting point for the tests here: e121717 (I've added a branch with changes from this PR on top of some changes done for ISSUE-283 for tests on Windows.) |
|
We'd need the conflicts fixed, but seems like nobody is around to review this other than me. Gulp. |
|
Bump? (I guess it's that time of year) |
|
@jonluca tagging you I’m if you’ve got time to have a look here. I’m not involved anymore. |
|
I'm open to a PR here but would need to update it to pass the tests and to use the new typescript repo. Closing this for now, feel free to open a new one |
|
Where's the new repo? |
|
It's this repo - all the code was migrated to TS ~8 months ago |
|
So I put the updates into a new PR: #322 But I have no idea if it's right, I've never used typescript before. |
Possibly corrects #200.
This however causes tests to fail as they’re not expecting the references to be resolved. I’m not sure yet how to fix the tests. I thought I’d wait to see if the fix is valid!
I'd love some feedback on this to progress it or change it!