Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] We should return the object itself and not as a Result<...> #20

Open
ANF-Studios opened this issue Jan 22, 2021 · 1 comment
Open

[FEATURE] We should return the object itself and not as a Result<...> #20

ANF-Studios opened this issue Jan 22, 2021 · 1 comment
Assignees
@ANF-Studios
Labels
enhancement New feature or request question Further information is requested

Comments

@ANF-Studios
Copy link
Member

Is your feature request related to a problem? Please describe.
As of now, returns are like so: Result<type, reqwest::Error> which just makes the user unwrap the method which can be a pain.

Describe the solution you'd like
Change the return type to type so it's easier.
@ANF-Studios ANF-Studios added enhancement New feature or request question Further information is requested labels Jan 22, 2021
@ANF-Studios ANF-Studios self-assigned this Jan 22, 2021
@ANF-Studios ANF-Studios changed the title [FEATURE] We should return the object itself and not the error [FEATURE] We should return the object itself and not as a Result<...> Jan 23, 2021
@ANF-Studios
Copy link
Member Author

I looked into this, I think that's how reqwest handles returns. And unwrapping requires us to use ? and there is no other way as far as I know. We might write our own implementation or use another lib if it's not possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ANF-Studios ANF-Studios

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ANF-Studios