-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IS-11] Fix occasional exceptions caused by undefined variables. #838
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1092,7 +1092,7 @@ def test_02_02_03_01(self, test): | |
return test.PASS() | ||
|
||
def test_02_02_03_02(self, test): | ||
"Verify that the video sender supports the minimum set of video constraints" | ||
"Verify that the audio sender supports the minimum set of audio constraints" | ||
|
||
sample = "^urn:x-nmos:cap:" | ||
|
||
|
@@ -3610,6 +3610,7 @@ def test_04_03(self, test): | |
connection_api_senders = IS05Utils(CONFIG.IS11_REFERENCE_SENDER_CONNECTION_API_URL).get_senders() | ||
|
||
for format in ["urn:x-nmos:format:video", "urn:x-nmos:format:audio"]: | ||
self.reference_senders[format] = [] | ||
for sender_id in connection_api_senders: | ||
valid, response = self.reference_is04_utils.checkCleanRequestJSON("GET", "senders/" + sender_id) | ||
if not valid: | ||
|
@@ -3674,9 +3675,10 @@ def test_04_03_01(self, test): | |
activated_receivers = response | ||
break | ||
try: | ||
if (activated_receivers < len(self.receivers_with_outputs)): | ||
if (activated_receivers < len(self.is11_utils.receivers_with_or_without_outputs)): | ||
return test.WARNING("There are no compatible senders for {} receivers" | ||
.format(len(self.receivers_with_outputs) - activated_receivers)) | ||
.format(len(self.is11_utils.receivers_with_or_without_outputs) | ||
- activated_receivers)) | ||
Comment on lines
-3679
to
+3681
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please replace |
||
except Exception: | ||
return test.UNCLEAR("No activated receivers") | ||
|
||
|
@@ -3809,9 +3811,10 @@ def test_04_03_02(self, test): | |
activated_receivers = response | ||
break | ||
try: | ||
if (activated_receivers < len(self.receivers_with_outputs)): | ||
if (activated_receivers < len(self.is11_utils.receivers_with_or_without_outputs)): | ||
Comment on lines
-3812
to
+3814
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please replace |
||
return test.WARNING("There are no compatible senders for {} receivers" | ||
.format(len(self.receivers_with_outputs) - activated_receivers)) | ||
.format(len(self.is11_utils.receivers_with_or_without_outputs) | ||
- activated_receivers)) | ||
Comment on lines
-3814
to
+3817
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please replace |
||
except Exception: | ||
return test.UNCLEAR("No activated receivers") | ||
|
||
|
@@ -3976,9 +3979,10 @@ def test_04_04_01(self, test): | |
activated_receivers = response | ||
break | ||
try: | ||
if (activated_receivers < len(self.receivers_without_outputs)): | ||
if (activated_receivers < len(self.is11_utils.receivers_with_or_without_outputs)): | ||
Comment on lines
-3979
to
+3982
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please replace |
||
return test.WARNING("There are no compatible senders for {} receivers" | ||
.format(len(self.receivers_without_outputs) - activated_receivers)) | ||
.format(len(self.is11_utils.receivers_with_or_without_outputs) | ||
- activated_receivers)) | ||
Comment on lines
-3981
to
+3985
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please replace |
||
except Exception: | ||
return test.UNCLEAR("No activated receivers") | ||
return test.PASS() | ||
|
@@ -4020,9 +4024,10 @@ def test_04_04_02(self, test): | |
activated_receivers = response | ||
break | ||
try: | ||
if (activated_receivers < len(self.receivers_without_outputs)): | ||
if (activated_receivers < len(self.is11_utils.receivers_with_or_without_outputs)): | ||
Comment on lines
-4023
to
+4027
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please replace |
||
return test.WARNING("There are no compatible senders for {} receivers" | ||
.format(len(self.receivers_without_outputs) - activated_receivers)) | ||
.format(len(self.is11_utils.receivers_with_or_without_outputs) | ||
- activated_receivers)) | ||
Comment on lines
-4025
to
+4030
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please replace |
||
except Exception: | ||
return test.UNCLEAR("No activated receivers") | ||
return test.PASS() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace
is11_utils.receivers_with_or_without_outputs
withself.receivers
.