Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More efficient PEtab parameter mapping #2639

Open
dweindl opened this issue Jan 30, 2025 · 0 comments
Open

More efficient PEtab parameter mapping #2639

dweindl opened this issue Jan 30, 2025 · 0 comments
Labels
performance PEtab PEtab-import related

Comments

@dweindl
Copy link
Member

dweindl commented Jan 30, 2025

For larger problems, create_parameter_mapping and fill_in_parameters can consume quite some time. This could be made more efficient:

  • parameter scale and plist should be computed only once and be stored in the parameter mapping
  • it should be clarified what needs to be updated in fill_in_parameters. Should it just recompute everything dependent on variable parameters, or every ExpData field?
  • much time is spent in both amici and libpetab for checking which model entities are state variables based on the SBML model. in the amici case, we already created the model beforehand and know which entities are state variables. this information should be used by both the petab and amici parameter mapping.
  • currently we have a two-stage parameter mapping, first libpetab, then amici. some parts are redundant, and it may be easier to have it completely in amici.
  • It should be clarified which ParameterMappingForCondition attributes are mutable so we can cache some quantities. Modification should only be allowed through a defined API that will update/clear caches as required.
  • Consider moving from dict-based mapping to ndarray-based mapping
@dweindl dweindl added performance PEtab PEtab-import related labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance PEtab PEtab-import related
Projects
None yet
Development

No branches or pull requests

1 participant