Split registry implementations #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
715209
force-pushed
the
push-wqwpwzltvlty
branch
3 times, most recently
from
8d2fb9a to
2168123
Compare
715209
force-pushed
the
push-wqwpwzltvlty
branch
3 times, most recently
from
331314f to
12c149f
Compare
715209
force-pushed
the
push-wqwpwzltvlty
branch
from
faab73a to
c9adba9
Compare
erikreinert
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
RegistryBackendtrait and splits the current registry implementations into two separate implementationsLocalRegistryBackendandS3RegistryBackend.I’m not too happy to include the box_clone in the trait (we probably don't need to clone), but it's probably fine for now.