redo pvar indexing logic & lazily load pvar file to save memory #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* root -> `row_nr()` not a recognized pl function Signed-off-by: Kyle Scott <kms309@miami.edu>
* in the case where the user decides to load an extremely large pvar file, it should not be read into memory immediately if the variants will be subset * has no negative impact on the case where the user loads all variants Signed-off-by: Kyle Scott <kms309@miami.edu>
Signed-off-by: Kyle Scott <kms309@miami.edu>
|
I see the issue - should be fixed in the third commit |
salcc
approved these changes
Nov 19, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7 and also adds some lazy functionality from polars. I did scrap this together rather quickly, so I suggest pulling down, running tests, and building any additional fixes on top of this.