-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding mode as aggfunc #194
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
=======================================
Coverage 99.62% 99.63%
=======================================
Files 9 9
Lines 1070 1086 +16
=======================================
+ Hits 1066 1082 +16
Misses 4 4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 1102 where you see if all the values in a series are unique.
sorting might take a while - could you just use https://pandas.pydata.org/docs/reference/api/pandas.Series.nunique.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the levels of indentation and the nu,mbersof line in this method near where you calculate threshold masks etc., (lines 742 onwards) , I wonder if it is time to refactor some of this code into a series of functions called something like get_mask_for_aggfuncc()
No description provided.