Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install torch_xla2 in GitHub action checks #27

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

tengyifei
Copy link
Collaborator

By default, torch_xla2 is not installed in our testing containers, which use the torch_xla docker. This fixes that.

Test: added a test to just import torch_xla2. Run pytest.

@tengyifei tengyifei requested a review from zpcore January 10, 2025 21:54
Copy link
Collaborator

@zpcore zpcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

By default, torch_xla2 is not installed in our testing containers, which
use the torch_xla docker. This fixes that.

Test: added a test to just import torch_xla2. Run `pytest`.
@tengyifei tengyifei force-pushed the yifeit/install-torch-xla2-in-check branch from 0a3c9b3 to 70fa3ae Compare January 10, 2025 22:16
@tengyifei tengyifei merged commit 29997e7 into main Jan 10, 2025
6 checks passed
zpcore pushed a commit that referenced this pull request Jan 11, 2025
By default, torch_xla2 is not installed in our testing containers, which
use the torch_xla docker. This fixes that.

Test: added a test to just import torch_xla2. Run `pytest`.
zpcore pushed a commit that referenced this pull request Jan 11, 2025
By default, torch_xla2 is not installed in our testing containers, which
use the torch_xla docker. This fixes that.

Test: added a test to just import torch_xla2. Run `pytest`.
@tengyifei tengyifei deleted the yifeit/install-torch-xla2-in-check branch January 26, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants