Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a torch and torchax roller #103

Open
tengyifei opened this issue Feb 10, 2025 · 0 comments
Open

Introduce a torch and torchax roller #103

tengyifei opened this issue Feb 10, 2025 · 0 comments

Comments

@tengyifei
Copy link
Collaborator

Currently CI uses the nightly build of PyTorch and PyTorch/XLA: https://github.com/AI-Hypercomputer/torchprime/blob/main/.github/workflows/cpu_test.yml

The E2E tests uses the 2.6 stable build: https://github.com/AI-Hypercomputer/torchprime/blob/main/torchprime/launcher/Dockerfile#L4

This means checks may just stop working at any point if there is an upstream introduced regression.

To prevent these kind of breakages, the standard practice is to use a roller:

  • We pin these docker images at some date
  • A bot (roller) makes a pull request to update the pin every day
  • The pull request is automatically merged if all the checks pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant