Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Enables the huggingface checkpoint conversion to MaxText orbax." #1300

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Revert "Enables the huggingface checkpoint conversion to MaxText orbax." #1300

merged 1 commit into from
Feb 22, 2025

Conversation

RissyRan
Copy link
Collaborator

@RissyRan RissyRan commented Feb 22, 2025 •
edited
Loading

Reverts #1291 to fix MaxText tests failures, as discussed in group chat.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@copybara-service copybara-service bot merged commit 02b9b8d into main Feb 22, 2025
17 of 19 checks passed
@copybara-service copybara-service bot deleted the revert-1291-lance-deepseek branch February 22, 2025 02:19
wang2yn84 added a commit that referenced this pull request Feb 22, 2025
@wang2yn84
Revert the revert "Merge pull request #1300 from AI-Hypercomputer:rev…
30acf84 
…ert-1291-lance-deepseek" and fix all the lint issues.

This reverts commit 02b9b8d, reversing
changes made to 7c9e7ba.
wang2yn84 added a commit that referenced this pull request Feb 22, 2025
@wang2yn84
Revert the revert "Merge pull request #1300 from AI-Hypercomputer:rev…
3228831 
…ert-1291-lance-deepseek" and fix all the lint issues.

This reverts commit 02b9b8d, reversing
changes made to 7c9e7ba.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khatwanimohit khatwanimohit khatwanimohit approved these changes

@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner

@bvandermoon bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RissyRan @khatwanimohit @shralex @wang2yn84 @vipannalla @gobbleturk