Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert 'Enables the huggingface checkpoint conversion to MaxText orbax.'" #1294

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Revert "Revert 'Enables the huggingface checkpoint conversion to MaxText orbax.'" #1294

merged 1 commit into from
Feb 22, 2025

Conversation

wang2yn84
Copy link
Collaborator

@wang2yn84 wang2yn84 commented Feb 21, 2025 •
edited
Loading

Description

Re-check-in the Enables the huggingface checkpoint conversion to MaxText orbax before the initial PR#1291 causes lint issues and presubmit failures. This PR reverts the revert and fixes all the failed checks.

Tests

Run through the tests and checks listed in the recipe for 8B model. For 70B, only have time to do the basic verification, e.g. the decode works.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

vipannalla
vipannalla approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@vipannalla vipannalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go after offline discussion with Ran, Mitali, and Lance. This PR doesn't break training tests.

@wang2yn84 wang2yn84 force-pushed the lance-deepseek branch 3 times, most recently from 74c28e7 to 189211a Compare February 22, 2025 09:02
@wang2yn84 wang2yn84 changed the title Follow up PR to #1291 Revert "Revert "Enables the huggingface checkpoint conversion to MaxText orbax."" Feb 22, 2025
@wang2yn84 wang2yn84 changed the title Revert "Revert "Enables the huggingface checkpoint conversion to MaxText orbax."" Revert "Revert ;Enables the huggingface checkpoint conversion to MaxText orbax.'" Feb 22, 2025
@wang2yn84 wang2yn84 changed the title Revert "Revert ;Enables the huggingface checkpoint conversion to MaxText orbax.'" Revert "Revert 'Enables the huggingface checkpoint conversion to MaxText orbax.'" Feb 22, 2025
@wang2yn84
Revert the revert "Merge pull request #1300 from AI-Hypercomputer:rev…
3228831 
…ert-1291-lance-deepseek" and fix all the lint issues.

This reverts commit 02b9b8d, reversing
changes made to 7c9e7ba.
@copybara-service copybara-service bot merged commit ed3b054 into main Feb 22, 2025
16 checks passed
@copybara-service copybara-service bot deleted the lance-deepseek branch February 22, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipannalla vipannalla vipannalla approved these changes

@singh-mitali singh-mitali singh-mitali approved these changes

@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner

@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner

@bvandermoon bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner

@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner

Assignees

@RissyRan RissyRan

@vipannalla vipannalla

Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wang2yn84 @vipannalla @singh-mitali @RissyRan