Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gpt3 test in parallel tests #1130

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

ZhiyuLi-goog
Copy link
Collaborator

@ZhiyuLi-goog ZhiyuLi-goog commented Dec 27, 2024

Description

Enable gpt3 test since not able to fully reproduce the failure b/386317358

Tests

Passed tests locally and in github runner.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@shralex
Copy link
Collaborator

shralex commented Dec 29, 2024

@ZhiyuLi-goog can we please try this again now that pr/1113 has merged

@ZhiyuLi-goog ZhiyuLi-goog force-pushed the lizhiyu/refactor_tests branch from 4cb0a27 to 4f5b828 Compare December 29, 2024 23:31
@ZhiyuLi-goog
Copy link
Collaborator Author

@ZhiyuLi-goog can we please try this again now that pr/1113 has merged

@shralex rebased and passed the test as well.

@shralex
Copy link
Collaborator

shralex commented Dec 30, 2024

Thanks for checking @ZhiyuLi-goog. If its not flaky I'm ok enabling the test.
Its strange -- it was previously consistently failing on CI. Here's an example: https://github.com/AI-Hypercomputer/maxtext/actions/runs/12495995229/job/34867292227

@ZhiyuLi-goog ZhiyuLi-goog changed the title [Do Not Merge] gpt3 test in parallel tests Enable gpt3 test in parallel tests Dec 30, 2024
@ZhiyuLi-goog
Copy link
Collaborator Author

Thanks for checking @ZhiyuLi-goog. If its not flaky I'm ok enabling the test. Its strange -- it was previously consistently failing on CI. Here's an example: https://github.com/AI-Hypercomputer/maxtext/actions/runs/12495995229/job/34867292227

Thank you @shralex. Enable this test now and we can always revisit it if we see the failure again.

@ZhiyuLi-goog ZhiyuLi-goog force-pushed the lizhiyu/refactor_tests branch from 4f5b828 to 96fd991 Compare December 30, 2024 03:44
@copybara-service copybara-service bot merged commit f4caa94 into main Dec 30, 2024
14 checks passed
@copybara-service copybara-service bot deleted the lizhiyu/refactor_tests branch December 30, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants