Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to just (binary_only / full_system) #2949

Merged
merged 63 commits into from
Feb 13, 2025
Merged

Move to just (binary_only / full_system) #2949

merged 63 commits into from
Feb 13, 2025

Conversation

rmalmain
Copy link
Member

@rmalmain rmalmain commented Feb 7, 2025

also, updates the main readme.

linked to #2924

@tokatoka
Copy link
Member

tokatoka commented Feb 7, 2025

you need to use the changed ci file from my branch

@tokatoka
Copy link
Member

tokatoka commented Feb 7, 2025

i merged

@tokatoka
Copy link
Member

tokatoka commented Feb 7, 2025

i take care of frida ones

@tokatoka
Copy link
Member

tokatoka commented Feb 7, 2025

Can you merge from this branch. I mistakenly disabled fuzzer CI before

@tokatoka
Copy link
Member

tokatoka commented Feb 7, 2025

i meant this branch #2952

@rmalmain
Copy link
Member Author

rmalmain commented Feb 7, 2025

i'll wait for #2924 to be merged before merging mine

@tokatoka
Copy link
Member

tokatoka commented Feb 9, 2025

Finally merged. Now it's your turn to suffer from this..

@rmalmain
Copy link
Member Author

rmalmain commented Feb 9, 2025

yeah, let's wrap up this

@tokatoka
Copy link
Member

./fuzzers/binary_only/tinyinst_simple/Makefile.toml
./fuzzers/binary_only/frida_windows_gdiplus/Makefile.toml
./fuzzers/binary_only/frida_libpng/Makefile.toml
./fuzzers/binary_only/frida_executable_libpng/Makefile.toml

these four i'll do

@rmalmain
Copy link
Member Author

no wait, i wrote what you did already
just didn't push yet

ping -n 10 127.0.0.1>NUL && taskkill /im frida_windows_gdiplus.exe /F
dir /a-d corpus_discovered && (echo Files exist) || (exit /b 1337)

[unix]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a bug

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is, thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nono this one doesn't have libpng
just cargo clean is fine

@@ -0,0 +1,49 @@
import "../../../just/libafl.just"

FUZZER_NAME := "frida_windows_gdiplus.exe"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when you run this on unix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a windows-only fuzzer, it's fine

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it print that it doesn't work at least?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will say cl.exe is not found so it's obvious

-lm -lz

[unix]
[macos]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is macos extra?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it's useless, they have a different convention from cargo-make apparently

--target-dir {{ TARGET_DIR }} \
--features "{{ api }}"

run api="": (build api)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WTF does this do? 😬

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run the rule for a given api.
default is empty, maybe not the most natural

--features "{{ api }}"

run api="": (build api)
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, to have env variables working with multiple lines recipes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do [script('/bin/bash')] too

@rmalmain rmalmain merged commit cb471a9 into main Feb 13, 2025
107 checks passed
@rmalmain rmalmain deleted the just_binonly branch February 13, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants