-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to just (binary_only / full_system) #2949
Conversation
you need to use the changed ci file from my branch |
i merged |
i take care of frida ones |
Can you merge from this branch. I mistakenly disabled fuzzer CI before |
i meant this branch #2952 |
i'll wait for #2924 to be merged before merging mine |
Finally merged. Now it's your turn to suffer from this.. |
yeah, let's wrap up this |
these four i'll do |
no wait, i wrote what you did already |
ping -n 10 127.0.0.1>NUL && taskkill /im frida_windows_gdiplus.exe /F | ||
dir /a-d corpus_discovered && (echo Files exist) || (exit /b 1337) | ||
|
||
[unix] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nono this one doesn't have libpng
just cargo clean is fine
@@ -0,0 +1,49 @@ | |||
import "../../../just/libafl.just" | |||
|
|||
FUZZER_NAME := "frida_windows_gdiplus.exe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when you run this on unix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a windows-only fuzzer, it's fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it print that it doesn't work at least?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will say cl.exe is not found so it's obvious
-lm -lz | ||
|
||
[unix] | ||
[macos] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is macos extra?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it's useless, they have a different convention from cargo-make apparently
--target-dir {{ TARGET_DIR }} \ | ||
--features "{{ api }}" | ||
|
||
run api="": (build api) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WTF does this do? 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run the rule for a given api.
default is empty, maybe not the most natural
--features "{{ api }}" | ||
|
||
run api="": (build api) | ||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, to have env variables working with multiple lines recipes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can do [script('/bin/bash')] too
also, updates the main readme.
linked to #2924