Re-add drcov for both usermode and systemmode. #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
export edge modules globally.
vringar
approved these changes
Sep 30, 2024
domenukk
reviewed
Sep 30, 2024
| @@ -18,7 +18,7 @@ pub mod systemmode; | |||
| pub use systemmode::*; | |||
|
|
|||
| pub mod edges; | |||
| pub use edges::EdgeCoverageModule; | |||
| pub use edges::*; | |||
There was a problem hiding this comment.
Not a fan of blanked imports tbh, there's even a clippy lint for that (and it can autofix)
There was a problem hiding this comment.
ah cool didn't know about this, could be good to do it
There was a problem hiding this comment.
@domenukk should that be part of scripts/autofix.sh? Because when I ran that, it didn't change it.
possibility to add module_mapping manually
|
@vringar i guess before you were setting the mapping manually to have it working in systemmode right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for bug inserted in #2267.
fixes #2572.