Versioning unification, dependencies update, logging optimization #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not compile low-level logs (< info level) by default update dependencies
|
maybe you shouldn't do this before we merge your fuzzer dir structure stuff |
|
yep it's also why i didn't continue for now. |
domenukk
reviewed
Sep 28, 2024
domenukk
reviewed
Sep 28, 2024
| @@ -228,38 +228,33 @@ pub(crate) fn frida_to_cs( | |||
| /// Get the `base`, `idx`, `scale`, `disp` for each operand | |||
| pub fn operand_details(operand: &Operand) -> Option<(X86Register, X86Register, u8, i32)> { | |||
| match operand { | |||
| Operand::RegDeref(base) => { | |||
There was a problem hiding this comment.
@s1341 can you see if that's all right?
fix format
tokatoka
force-pushed
the
crate_versioning_log_policy
branch
from
71ccbff
to
06ada21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's wip, i'll wait feedback to continue. any opinion on this? (cc @domenukk @tokatoka)