Inspiration's Fitted Carpets breaks Chisel's Carving alternates #401
WaitingIdly
started this conversation in
Bugfix Suggestions
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
When both Chisel & Inspirations are loaded, Chisel has an issue properly using some of its Carving alternates, specifically the ones for carpets. Additionally, any modification of Chisel's Carving registry, such as by GroovyScript or CraftTweaker, causes errors, specifically an NPE at or around here (bit hard to tell) [0].
This is caused by Inspirations replacing the vanilla carpet to allow vanilla carpets to mold to stairs [1] and thus breaking chisel groups. It is an open issue for Chisel [2] and a "closed due to 1.12.2 no longer being supported" for Inspirations [3]. It can be avoided via changing Inspiration's config on line 350 to
B:fittedCarpets=false
, which defaults totrue
.A simple and unsatisfactory solution is to simply disable this config option if Chisel is installed.
Another possible solution is to rewrite how Inspirations handles its replacements of vanilla carpets, which is done by Inspirations here [4], so that it doesn't break Chisel's Carving alternates registry.
Currently, Inspirations only works for Vanilla carpets, and carpets added by other mods do not get their changes. As a feature change, Universal Tweaks could apply the ability to mold to stairs to any carpet via a mixin of the BlockCarpet class (and then disable the Inspirations change).
[0] https://github.com/Chisel-Team/Chisel/blob/a0df1047a979bc55b3c81d5875e6890c21063bec/src/main/java/team/chisel/common/carving/GroupList.java#L263
[1] https://github.com/KnightMiner/Inspirations/blob/1.12/src/main/java/knightminer/inspirations/tweaks/block/BlockFittedCarpet.java
[2] Chisel-Team/Chisel#828
[3] KnightMiner/Inspirations#161
[4] https://github.com/KnightMiner/Inspirations/blob/1.12/src/main/java/knightminer/inspirations/tweaks/InspirationsTweaks.java#L99
Beta Was this translation helpful? Give feedback.
All reactions