Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nci-openmpi: use env.append_flags() #63

Merged
merged 1 commit into from
Feb 12, 2024
Merged

nci-openmpi: use env.append_flags() #63

merged 1 commit into from
Feb 12, 2024

Conversation

harshula
Copy link
Collaborator

  • Use env.append_flags() instead of env.append_path().
  • Thanks to Aidan Heerdegen for finding env.append_flags().

@harshula
nci-openmpi: use env.append_flags()
ed86d7a 
* Use env.append_flags() instead of env.append_path().
* Thanks to Aidan Heerdegen for finding env.append_flags().
@harshula harshula self-assigned this Feb 12, 2024
@harshula
Copy link
Collaborator Author

With Spack v0.20, the bug was:

  Imported target "MPI::MPI_Fortran" includes non-existent path

    "/apps/openmpi/4.0.2/include/Intel:-I/apps/openmpi/4.0.2/include/Intel"

With this patch on Spack v0.20:

OMPI_FCFLAGS -I/apps/openmpi/4.0.2/include/Intel
OMPI_LDFLAGS -L/apps/openmpi/4.0.2/lib -L/apps/openmpi/4.0.2/lib/Intel

With this patch on Spack v0.21:

OMPI_FCFLAGS -I/apps/openmpi/4.0.2/include/Intel -I/apps/openmpi/4.0.2/include/Intel -I/apps/openmpi/4.0.2/include/Intel -I/apps/openmpi/4.0.2/include/Intel
OMPI_LDFLAGS -L/apps/openmpi/4.0.2/lib -L/apps/openmpi/4.0.2/lib/Intel -L/apps/openmpi/4.0.2/lib -L/apps/openmpi/4.0.2/lib/Intel -L/apps/openmpi/4.0.2/lib -L/apps/openmpi/4.0.2/lib/Intel -L/apps/openmpi/4.0.2/lib -L/apps/openmpi/4.0.2/lib/Intel

The duplication in Spack v0.21 appears to be due to Spack commit 72b36ac14446782f47519db8ee5cff6631b2b4c9.

aidanheerdegen
aidanheerdegen approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshula
Copy link
Collaborator Author

Closes #62

@harshula harshula merged commit 5a1c6cb into main Feb 12, 2024
1 check failed
@harshula harshula deleted the 62-use-append_flags branch February 12, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanheerdegen aidanheerdegen aidanheerdegen approved these changes

Assignees

@harshula harshula

Labels
None yet
Projects
ACCESS-NRI Infrastructure
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshula @aidanheerdegen