Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package recipe for ACCESS-TEST-model #206

Merged
merged 5 commits into from
Mar 6, 2025

Conversation

aidanheerdegen
Copy link
Member

Add package recipe for test stub model component

Closes #205

Copy link
Member Author

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of completeness this doesn't work, seems it's not building with MPI compilers

$ spack list access-test-model
==> Warning: Skipping package at /g/data/xxxx/aaa999/spack/0.22/spack-packages/packages/v4.24. "v4.24" is not a valid Spack module name.
access-test-model
==> 1 packages
[aaa999@gadi-login-04 0.22]$ spack install access-test-model
==> Warning: Skipping package at /g/data/xxxx/aaa999/spack/0.22/spack-packages/packages/v4.24. "v4.24" is not a valid Spack module name.
==> Fetching https://mirror.spack.io/bootstrap/github-actions/v0.5/build_cache/linux-centos7-x86_64-gcc-10.2.1-clingo-bootstrap-spack-smkmkb5xqz4v2f7tl22g4e2ghamglox5.spec.json
==> Fetching https://mirror.spack.io/bootstrap/github-actions/v0.5/build_cache/linux-centos7-x86_64/gcc-10.2.1/clingo-bootstrap-spack/linux-centos7-x86_64-gcc-10.2.1-clingo-bootstrap-spack-smkmkb5xqz4v2f7tl22g4e2ghamglox5.spack
==> Installing "clingo-bootstrap@=spack%gcc@=10.2.1~docs+ipo+optimized+python+static_libstdcpp build_system=cmake build_type=Release generator=make patches=bebb819,ec99431 arch=linux-centos7-x86_64" from a buildcache
[+] /apps/cmake/3.24.2 (external cmake-3.24.2-iv7kaf2h7mjjfmnhzlyozlxixmz7zkmv)
[+] /usr (external glibc-2.28-rmko4qyyetyn6neqs7tnuusqbllgwbnb)
==> openmpi@4.1.5 : has external module in ['openmpi/4.1.5']
[+] /apps/openmpi/4.1.5 (external openmpi-4.1.5-ik77peh7s67lxquht3pskzbgra4lt6s5)
[+] /g/data/xxxx/aaa999/spack/0.22/release/linux-rocky8-x86_64_v4/gcc-14.1.0/gcc-runtime-14.1.0-qukvuocm7w3d226pa4tnari6lgx4daoa
[+] /g/data/xxxx/aaa999/spack/0.22/release/linux-rocky8-x86_64_v4/gcc-14.1.0/gmake-4.4.1-ex2epk42mxz2coib6coiqapoztkdgrhg
==> Installing access-test-model-main-veiye6zgxxmwld4glky3ezucdclljcwn [6/6]
==> No binary for access-test-model-main-veiye6zgxxmwld4glky3ezucdclljcwn found: installing from source
==> No patches needed for access-test-model
==> access-test-model: Executing phase: 'cmake'
==> access-test-model: Executing phase: 'build'
==> Error: ProcessError: Command exited with status 2:
    'make' '-j16'

8 errors found in build log:
     31    [ 50%] Building Fortran object CMakeFiles/hello_world.exe.dir/src/hello_world.f90.o
     32    /g/data/xxxx/aaa999/spack/0.22/spack/lib/spack/env/gcc/gfortran   -O3 -DNDEBUG -O3 -c /scratch/xxxx/aaa999/tmp/spack-stag
           e/spack-stage-access-test-model-main-veiye6zgxxmwld4glky3ezucdclljcwn/spack-src/stub/src/hello_world.f90 -o CMakeFiles/he
           llo_world.exe.dir/src/hello_world.f90.o
     33    [100%] Linking Fortran executable hello_world.exe
     34    /apps/cmake/3.24.2/bin/cmake -E cmake_link_script CMakeFiles/hello_world.exe.dir/link.txt --verbose=1
     35    /g/data/xxxx/aaa999/spack/0.22/spack/lib/spack/env/gcc/gfortran -O3 -DNDEBUG -O3 CMakeFiles/hello_world.exe.dir/src/hello
           _world.f90.o -o hello_world.exe  -Wl,-rpath,:::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
           :::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
           :::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
           :::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
     36    CMakeFiles/hello_world.exe.dir/src/hello_world.f90.o: In function `MAIN__':
  >> 37    hello_world.f90:(.text+0x25): undefined reference to `mpi_init_'
  >> 38    hello_world.f90:(.text+0x35): undefined reference to `mpi_comm_size_'
  >> 39    hello_world.f90:(.text+0x45): undefined reference to `mpi_comm_rank_'
  >> 40    hello_world.f90:(.text+0xbe): undefined reference to `mpi_finalize_'
  >> 41    collect2: error: ld returned 1 exit status
  >> 42    make[2]: *** [CMakeFiles/hello_world.exe.dir/build.make:99: hello_world.exe] Error 1
     43    make[2]: Leaving directory '/scratch/xxxx/aaa999/tmp/spack-stage/spack-stage-access-test-model-main-veiye6zgxxmwld4glky3e
           zucdclljcwn/spack-build-veiye6z'
  >> 44    make[1]: *** [CMakeFiles/Makefile2:86: CMakeFiles/hello_world.exe.dir/all] Error 2
     45    make[1]: Leaving directory '/scratch/xxxx/aaa999/tmp/spack-stage/spack-stage-access-test-model-main-veiye6zgxxmwld4glky3e
           zucdclljcwn/spack-build-veiye6z'
  >> 46    make: *** [Makefile:139: all] Error 2

See build log for details:
  /scratch/xxxx/aaa999/tmp/spack-stage/spack-stage-access-test-model-main-veiye6zgxxmwld4glky3ezucdclljcwn/spack-build-out.txt

@aidanheerdegen
Copy link
Member Author

Doesn't work with intel compiler either

spack install access-test-model %intel@2021.10.0

I guess I'll need to default to MPI compilers in the CMakelists.txt

@aidanheerdegen
Copy link
Member Author

Fixed the model component build and now it works:

ACCESS-NRI/access-test-model#1 (comment)

$ spack install access-test-model@git.6631ceda17ea366e9b1d628f1f9779aaba0a74b2%intel@2021.10.0
$ spack load access-test-model
$ mpirun -n 6 $(which hello_world.exe)
 Hello World from process:            1 of            6
 Hello World from process:            2 of            6
 Hello World from process:            3 of            6
 Hello World from process:            4 of            6
 Hello World from process:            5 of            6
 Hello World from process:            0 of            6
$

@aidanheerdegen aidanheerdegen requested a review from harshula March 5, 2025 04:13
aidanheerdegen and others added 2 commits March 6, 2025 14:48
Co-authored-by: Harshula Jayasuriya <harshula.jayasuriya@anu.edu.au>
@aidanheerdegen aidanheerdegen merged commit c97ce7c into main Mar 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add spack package for test model component
2 participants