-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
access-om2 SPRs: change the name of the default version #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
harshula
commented
Jan 30, 2025
- Originally there was only one version in each SPR. It was used to build access-om2. However, now we have more versions like access-esm1.5. By renaming version "master" to "access-om2", it is clear that is the version used to build access-om2.
- Use the new maintainers() function.
Testing
@@ -9,16 +9,16 @@ spack:
packages:
cice5:
require:
- - '@git.2023.10.19'
+ - '@git.2023.10.19=access-om2'
mom5:
require:
- - '@git.2023.11.09'
+ - '@git.2023.11.09=access-om2'
libaccessom2:
require:
- - '@git.2023.10.26'
+ - '@git.2023.10.26=access-om2'
oasis3-mct:
require:
- - '@git.2023.11.09'
+ - '@git.2023.11.09=access-om2'
netcdf-c:
require:
- '@4.7.4' |
* Originally there was only one version in each SPR. It was used to build access-om2. However, now we have more versions like access-esm1.5. By renaming version "master" to "access-om2", it is clear that is the version used to build access-om2. * Update access-om2 SBR too. * Use the new maintainers() function.
8fe48a4
to
d6c992e
Compare
dougiesquire
approved these changes
Jan 31, 2025
Testing@@ -5,7 +5,7 @@
spack:
# add package specs to the `specs` list
specs:
- - access-om2@git.2024.03.0
+ - access-om2@git.2024.03.0=access-om2
packages:
cice5:
require:
|
@harshula, a random tip: if you put your diff codeblocks in ```diff they get coloured nicely 😎 |
CodeGat
approved these changes
Jan 31, 2025
harshula
commented
Mar 6, 2025
@@ -16,7 +16,7 @@ class AccessOm2(BundlePackage): | |||
|
|||
maintainers("harshula") | |||
|
|||
version("latest") | |||
version("access-om2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to revert this back to latest
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.