Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access-om2 SPRs: change the name of the default version #185

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

harshula
Copy link
Collaborator

  • Originally there was only one version in each SPR. It was used to build access-om2. However, now we have more versions like access-esm1.5. By renaming version "master" to "access-om2", it is clear that is the version used to build access-om2.
  • Use the new maintainers() function.

@harshula
Copy link
Collaborator Author

harshula commented Jan 30, 2025

Testing

@@ -9,16 +9,16 @@ spack:
   packages:
     cice5:
       require:
-        - '@git.2023.10.19'
+        - '@git.2023.10.19=access-om2'
     mom5:
       require:
-        - '@git.2023.11.09'
+        - '@git.2023.11.09=access-om2'
     libaccessom2:
       require:
-        - '@git.2023.10.26'
+        - '@git.2023.10.26=access-om2'
     oasis3-mct:
       require:
-        - '@git.2023.11.09'
+        - '@git.2023.11.09=access-om2'
     netcdf-c:
       require:
         - '@4.7.4'

* Originally there was only one version in each SPR. It was used
  to build access-om2. However, now we have more versions like
  access-esm1.5. By renaming version "master" to "access-om2",
  it is clear that is the version used to build access-om2.
* Update access-om2 SBR too.
* Use the new maintainers() function.
@harshula harshula force-pushed the access-om2-update-spack-version branch from 8fe48a4 to d6c992e Compare January 30, 2025 23:52
@harshula
Copy link
Collaborator Author

harshula commented Jan 31, 2025

Testing

@@ -5,7 +5,7 @@
 spack:
   # add package specs to the `specs` list
   specs:
-    - access-om2@git.2024.03.0
+    - access-om2@git.2024.03.0=access-om2
   packages:
     cice5:
       require:
[om2-version-access-om2] [root@4d585f76c0b3 opt]# spack concretize -f --reuse-deps
==> Concretized access-om2@git.2024.03.0=access-om2
...
[om2-version-access-om2] [root@4d585f76c0b3 opt]# spack install
...
==> Waiting for access-om2-git.2024.03.0=access-om2-yq2bx7bbiehmtzcowfxfmmfdusot==> Installing access-om2-git.2024.03.0=access-om2-yq2bx7bbiehmtzcowfxfmmfdusotfc36 [35/35]
==> No binary for access-om2-git.2024.03.0=access-om2-yq2bx7bbiehmtzcowfxfmmfdusotfc36 found: installing from source
==> No patches needed for access-om2
==> access-om2: Executing phase: 'install'
==> Warning: Module file /opt/release/modules/linux-rocky8-x86_64/access-om2/2024.03.0 exists and will not be overwritten
==> access-om2: Successfully installed access-om2-git.2024.03.0=access-om2-yq2bx7bbiehmtzcowfxfmmfdusotfc36
  Stage: 0.00s.  Install: 0.00s.  Post-install: 0.04s.  Total: 0.13s
[+] /opt/release/linux-rocky8-x86_64/intel-2021.2.0/access-om2-git.2024.03.0_access-om2-yq2bx7bbiehmtzcowfxfmmfdusotfc36
==> Updating view at /opt/environments/om2-version-access-om2/.spack-env/view

@dougiesquire
Copy link
Contributor

@harshula, a random tip: if you put your diff codeblocks in

```diff

```

they get coloured nicely 😎

@harshula harshula merged commit db2fd8c into main Jan 31, 2025
1 check failed
@harshula harshula deleted the access-om2-update-spack-version branch January 31, 2025 01:22
@@ -16,7 +16,7 @@ class AccessOm2(BundlePackage):

maintainers("harshula")

version("latest")
version("access-om2")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to revert this back to latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants