Spack Components for OM3 #171

anton-seaice · 2024-11-27T05:22:08Z

This is an extremely draft collection of changes to spack-packages to build OM3 by component.

I've been building access3-share with '+install_libraries' in the spec, I haven't looked at building with an executable yet

I've been using these git versions :

https://github.com/ACCESS-NRI/CICE/tree/5-port_cmake_build

and

https://github.com/ACCESS-NRI/access3-share/tree/share_prototype

Example deployment: ACCESS-NRI/ACCESS-OM3#35

…gsi8.1" This reverts commit 5d72a48.

anton-seaice · 2024-12-04T02:35:12Z

Contributes to #163

…-components

anton-seaice · 2025-01-14T01:02:57Z

This is still a draft but is ready for a review for style / approach.

I've only implemented for CICE6 at this point, see the example deployment in ACCESS-NRI/ACCESS-OM3#35

packages/access3-exe/package.py

Copied from access-om3-nuopc package

packages/access-mom6/package.py

packages/access-cice/package.py

anton-seaice · 2025-02-04T23:15:42Z

packages/access-cice/package.py

+    url = "https://github.com/CICE-Consortium/CICE/archive/refs/tags/CICE6.6.0.tar.gz"
+    version("6.6.0", md5="1c678c0af67bf09f92c0a861344c3a92")


Suggested change

url = "https://github.com/CICE-Consortium/CICE/archive/refs/tags/CICE6.6.0.tar.gz"

version("6.6.0", md5="1c678c0af67bf09f92c0a861344c3a92")

Shall we pre-emptively create a version("access-om3", branch="main") here ?

How does this interact with the access3 variant?

The CMake build will pick the correct "driver" code to work with dependencies built in access3-share

a.k.a the customisation in our fork are not essential for the model to build, but misses some nice to have customisation in our fork

I am not sure thats the question ?

packages/access3-exe/package.py

aidanheerdegen

Hope that is helpful

aidanheerdegen · 2025-02-26T05:32:07Z

packages/access-cice/package.py

+    depends_on("cmake@3.18:", type="build")
+    depends_on("mpi")
+    depends_on("netcdf-fortran@4.6.0:", when="io_type=NetCDF")
+    depends_on("parallelio@2.5.10: build_type==RelWithDebInfo", when="io_type=PIO")


This is overriding the global build_type variant. Is that intentional?

I fear this turns off some optimisation which needs to be off for bfb repro, Ill investigate

aidanheerdegen · 2025-02-26T05:38:09Z

packages/access3-share/package.py

+        "build_type",
+        default="Release",
+        description="The build type to build",
+        values=("Debug", "Release"),


No option for RelWithDebInfo?

aidanheerdegen · 2025-02-26T05:39:53Z

packages/access3-share/package.py

+    depends_on("esmf cflags='-fp-model precise' fflags='-fp-model precise'", when="%intel")
+    depends_on("fortranxml@4.1.2:")
+
+    depends_on("parallelio@2.5.10: build_type==RelWithDebInfo")


build_type hard-coded.

aidanheerdegen · 2025-02-26T05:40:44Z

packages/access-cice/package.py

+        "build_type",
+        default="Release",
+        description="The build type to build",
+        values=("Debug", "Release"),


No RelWithDebInfo option?

aidanheerdegen · 2025-02-26T05:41:07Z

packages/access-mom6/package.py

+    depends_on("cmake@3.18:", type="build")
+    depends_on("mpi")
+    depends_on("netcdf-fortran@4.6.0:")
+    depends_on("fms@2021.03: build_type==RelWithDebInfo precision=64 +large_file ~gfs_phys ~quad_precision")


Hard codes build_type and there is no build_type variant as there is in other packages.

aidanheerdegen · 2025-02-26T05:41:41Z

packages/access-mom6/package.py

+        args.append(self.define("CMAKE_C_COMPILER", self.spec["mpi"].mpicc))
+        args.append(self.define("CMAKE_CXX_COMPILER", self.spec["mpi"].mpicxx))
+        args.append(self.define("CMAKE_Fortran_COMPILER", self.spec["mpi"].mpifc))


These should no longer be necessary.

aidanheerdegen · 2025-02-26T05:43:43Z

packages/access3-exe/package.py

+        args.append(self.define("CMAKE_C_COMPILER", self.spec["mpi"].mpicc))
+        args.append(self.define("CMAKE_CXX_COMPILER", self.spec["mpi"].mpicxx))
+        args.append(self.define("CMAKE_Fortran_COMPILER", self.spec["mpi"].mpifc))


Should no longer be needed I believe.

aidanheerdegen · 2025-02-26T05:46:50Z

packages/access3-exe/package.py

+    depends_on("mpi")
+
+    for configurations in ["CICE6", "MOM6-CICE6", "MOM6-CICE6-WW3", "CICE6-WW3"]:
+        depends_on("access-cice+cesmcoupled+access3")


Is this short-hand for:

depends_on("access-cice") depends_on("cesmcoupled") depends_on("access3")

No cesmcoupled and access3 are variants in the access-cice package

aidanheerdegen · 2025-02-26T05:47:29Z

packages/access3-exe/package.py

Is there a reason to have this separate package? Couldn't all this be just be put in the access-mom6 package?

That is the extent of my high-level feedback. The rest is pretty low level I'm afraid.

Did you leave this comment on the correct file ?

access3-exe uses different code to access-mom6 ...

We will at some point build models which don't include MOM6

Sorry, I make a mistake in my comment:

Is there a reason to have this separate package? Couldn't all this be just be put in the access-om3 package?

Does that make more sense?

I don't understand how versioning and CD would work if we did this.

i.e.

the version on the access-om3 deployment, is the version of a git tag in the access-nri/access-om3 release

the version on access3-exe is the version from the source code, i.e. the access-nri/access3-share repo

So I think we need a bundle package so we have something to version ? (ping @CodeGat )

packages/access3-exe/package.py

anton-seaice and others added 12 commits October 23, 2024 15:00

hacks to build https://github.com/ACCESS-NRI/cice5/tree/cice_gsi8.1

5d72a48

draft of changes

6e9c3f6

attempt at a cice package

b944115

draft of MOM6 package

c984bee

add invariant

c53d2b9

beginnings of an access share package

2001f54

Revert "hacks to build https://github.com/ACCESS-NRI/cice5/tree/cice_…

9d856f8

…gsi8.1" This reverts commit 5d72a48.

Merge remote-tracking branch 'origin/main' into 163-om3-components

4e4908e

revert cice5

42eb0fc

improvements

0aaeca1

Update MOM6/package.py

7f93dbc

increments

2944f7a

anton-seaice marked this pull request as draft November 29, 2024 04:29

anton-seaice added 5 commits December 6, 2024 11:31

Merge remote-tracking branch 'origin/163-om3-components' into 163-om3…

a2d610d

…-components

increments

79d34bb

rename to access-cice & make access3-exe and other experiments

6e6421c

Merge remote-tracking branch 'origin/main' into 163-om3-components

b8b394a

working draft of OM3 build (with CICE only)

d2dab1f

anton-seaice mentioned this pull request Jan 14, 2025

Update spack.yaml to demonstrate new spack packages ACCESS-NRI/ACCESS-OM3#35

Draft

3 tasks

anton-seaice added 4 commits January 14, 2025 12:04

formatting

b167ae5

whitespace

ed3b028

whitespace

b72c6e0

fix define

bd2bca8

anton-seaice requested review from harshula, aidanheerdegen and CodeGat January 14, 2025 03:59

anton-seaice mentioned this pull request Jan 14, 2025

Share prototype ACCESS-NRI/access3-share#2

Draft

1 task

anton-seaice removed the request for review from CodeGat January 14, 2025 04:00

minghangli-uni and others added 4 commits January 21, 2025 10:19

Remove mom6

d3aff02

add access-mom6

2a0ad48

resolves whitespaces

f91f2be

Update package.py

f2def26

anton-seaice commented Jan 21, 2025

View reviewed changes

packages/access3-exe/package.py Outdated Show resolved Hide resolved

anton-seaice and others added 5 commits January 21, 2025 15:19

submodules = True

a8e8a5f

Missing fms precision

2a4b0f1

Copied from access-om3-nuopc package

new cmakelist dir

07fc321

remove mom6_exec variant

49bde52

Fix syntax errors

3ac4aea

anton-seaice commented Jan 23, 2025

View reviewed changes

packages/access-mom6/package.py Outdated Show resolved Hide resolved

anton-seaice commented Jan 23, 2025

View reviewed changes

packages/access-mom6/package.py Outdated Show resolved Hide resolved

name tweaks

71561ad

anton-seaice commented Jan 23, 2025

View reviewed changes

packages/access-cice/package.py Outdated Show resolved Hide resolved

Update packages/access-cice/package.py

f219d71

This was referenced Jan 29, 2025

Demo build using new spack packages ACCESS-NRI/access-om3-configs#164

Draft

Deploy new ACCESS-OM3 0.4.0 using COSIMA build system ACCESS-NRI/ACCESS-OM3#39

Merged

anton-seaice commented Feb 4, 2025

View reviewed changes

anton-seaice added 2 commits February 6, 2025 10:14

possibly better build curation

30d37f2

comment out unused lines

be5bfcf

anton-seaice commented Feb 24, 2025

View reviewed changes

packages/access3-exe/package.py Outdated Show resolved Hide resolved

Update packages/access3-exe/package.py

174fcb5

anton-seaice commented Feb 24, 2025

View reviewed changes

packages/access3-exe/package.py Outdated Show resolved Hide resolved

anton-seaice and others added 3 commits February 25, 2025 10:27

Update packages/access3-exe/package.py

4bede53

Merge remote-tracking branch 'origin/main' into 163-om3-components

94b9cb6

try without CMAKE compiler flags in package

30abf59

aidanheerdegen reviewed Feb 26, 2025

View reviewed changes

anton-seaice added 3 commits February 27, 2025 12:22

some tidyups and review comments

957a4c8

messing around with configurations validation

9b6c462

fix handing of deps

2b84afc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spack Components for OM3 #171

Spack Components for OM3 #171

anton-seaice commented Nov 27, 2024 •

edited

Loading

anton-seaice commented Dec 4, 2024

anton-seaice commented Jan 14, 2025

anton-seaice Feb 4, 2025 •

edited

Loading

aidanheerdegen Feb 26, 2025

anton-seaice Feb 26, 2025

aidanheerdegen left a comment

aidanheerdegen Feb 26, 2025

anton-seaice Feb 27, 2025

aidanheerdegen Feb 26, 2025

aidanheerdegen Feb 26, 2025

aidanheerdegen Feb 26, 2025

aidanheerdegen Feb 26, 2025

aidanheerdegen Feb 26, 2025

aidanheerdegen Feb 26, 2025

aidanheerdegen Feb 26, 2025

anton-seaice Feb 27, 2025

aidanheerdegen Feb 26, 2025

aidanheerdegen Feb 26, 2025

anton-seaice Feb 27, 2025

aidanheerdegen Mar 6, 2025

anton-seaice Mar 6, 2025

		url = "https://github.com/CICE-Consortium/CICE/archive/refs/tags/CICE6.6.0.tar.gz"
		version("6.6.0", md5="1c678c0af67bf09f92c0a861344c3a92")

Spack Components for OM3 #171

Are you sure you want to change the base?

Spack Components for OM3 #171

Conversation

anton-seaice commented Nov 27, 2024 • edited Loading

anton-seaice commented Dec 4, 2024

anton-seaice commented Jan 14, 2025

anton-seaice Feb 4, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aidanheerdegen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anton-seaice commented Nov 27, 2024 •

edited

Loading

anton-seaice Feb 4, 2025 •

edited

Loading