Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Apparently) Inconsistent compiler flags in um7 package.py #196

Open
manodeep opened this issue Feb 18, 2025 · 2 comments
Open

(Apparently) Inconsistent compiler flags in um7 package.py #196

manodeep opened this issue Feb 18, 2025 · 2 comments
Assignees

Comments

@manodeep
Copy link
Contributor

These lines do not contain the architecture flag - which is currently set to -xCORE-AVX512 in this line. However that {FARCH} line is used in the C compiler flag: here. Are these intentional and necessary choices?

Similarly, some places have -fp-model strict while others are -fp-model precise - is that intentional as well?

@penguian
Copy link
Contributor

penguian commented Mar 5, 2025

Being able to have different flags for different compilation units is considered to be a feature of fcm make. As to why these flags were used for these particular files, it may come down to working around bugs that existed at the time. Unfortunately, much of the Trac and Subversion history of ACCESS-ESM1.5 has been lost, due to the decommissioning of trac.nci.org.au and accessdev.nci.org.au. One relevant Accessdev Wiki page has been archived: https://github.com/ACCESS-NRI/accessdev-Trac-archive/wiki/access_build_oasis3

See also https://github.com/ACCESS-NRI/UM7/blob/dev-access-esm1.6/ummodel_hg3/cfg/bld-hadgem3-mct.cfg

In summary, the choices are historical and the reasoning is lost. You may experiment with it, but there is no guarantee that the built executable will remain bitwise compatible and bug-free.

@penguian
Copy link
Contributor

penguian commented Mar 5, 2025

@manodeep @harshula Can I close this issue as WONTFIX?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Status: No status
Status: New Issues 🌅
Development

No branches or pull requests

2 participants