Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update au.org.access-nri/model/spack/environment/deployment schema to 1-0-3: Allow variants in spec string #39

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

CodeGat
Copy link
Member

@CodeGat CodeGat commented Dec 2, 2024

In this PR:

  • Update spack.yaml deployment schema to allow for variants in the spack.spec string.
  • Also update the CHANGELOG

To see the diff better, since they are two different files, run diff au.org.access-nri/model/spack/environment/deployment/1-0-2.json au.org.access-nri/model/spack/environment/deployment/1-0-3.json

To use this version of the schema in your Model Deployment Repository, set the following variable: gh variable set SPACK_YAML_SCHEMA_VERSION --body '1-0-3' --repo access-nri/MODEL

References ACCESS-NRI/build-cd#180

@CodeGat CodeGat self-assigned this Dec 2, 2024
@CodeGat CodeGat requested a review from harshula December 2, 2024 22:31
@CodeGat CodeGat force-pushed the build-cd-180-spec-allow-variants branch 3 times, most recently from e69f15f to 554f753 Compare December 2, 2024 22:48
@CodeGat CodeGat removed the request for review from harshula December 2, 2024 22:57
@CodeGat CodeGat marked this pull request as draft December 2, 2024 22:57
@CodeGat CodeGat changed the title Update au.org.access-nri.model.spack.environment/deployment schema to 1-0-3: Allow variants in spec string Update au.org.access-nri/model/spack/environment/deployment schema to 1-0-3: Allow variants in spec string Dec 2, 2024
@CodeGat CodeGat marked this pull request as ready for review December 2, 2024 23:38
@CodeGat CodeGat requested a review from harshula December 3, 2024 02:15
…to `1-0-3`: Allow variants after version in spec string
@CodeGat CodeGat force-pushed the build-cd-180-spec-allow-variants branch from e5eee7a to 66ffef1 Compare December 3, 2024 04:42
Copy link

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@CodeGat CodeGat merged commit 1eeec56 into main Dec 3, 2024
@CodeGat CodeGat deleted the build-cd-180-spec-allow-variants branch December 3, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

2 participants