Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACCESS-OM3: Empty QA Checks #40

Merged
merged 4 commits into from
Aug 6, 2024
Merged

ACCESS-OM3: Empty QA Checks #40

merged 4 commits into from
Aug 6, 2024

Conversation

CodeGat
Copy link
Member

@CodeGat CodeGat commented Aug 6, 2024

We add empty OM3 QA checks in order to pass the QA section of the workflow for ACCESS-OM3. This PR will require a bump to the model-config-tests package version (from 0.0.1 to 0.0.2.

In this PR:

  • Add empty OM3 QA test cases
  • Add new access_om3 pytest marker
  • Update version to 0.0.2

@CodeGat CodeGat added priority:high type:qa-check Quality Assurance Checks labels Aug 6, 2024
@CodeGat CodeGat self-assigned this Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.12%. Comparing base (13472bf) to head (a96160d).
Report is 17 commits behind head on main.

Files Patch % Lines
src/model_config_tests/test_access_om3_config.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   54.85%   55.12%   +0.27%     
==========================================
  Files          13       14       +1     
  Lines         618      624       +6     
==========================================
+ Hits          339      344       +5     
- Misses        279      280       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeGat CodeGat merged commit f9d1bee into main Aug 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high type:qa-check Quality Assurance Checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants